Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1115)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java

Issue 913593002: Don't fire error messages if an install kills Chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
index db9c507f043189b0522282760db2a57377302d43..ecffb299f387abd224728293bb631e33901d39e4 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
@@ -176,8 +176,7 @@ public class AppBannerManager extends EmptyTabObserver {
// Try installing the app. If the installation was kicked off, return false to prevent
// the infobar from disappearing.
return !mTab.getWindowAndroid().showIntent(
- appData.installIntent(), createIntentCallback(appData),
- R.string.low_memory_error);
+ appData.installIntent(), createIntentCallback(appData), null);
}
}
@@ -215,16 +214,7 @@ public class AppBannerManager extends EmptyTabObserver {
@CalledByNative
private void showAppDetails(AppData appData) {
- WindowAndroid.IntentCallback emptyCallback = new WindowAndroid.IntentCallback() {
- @Override
- public void onIntentCompleted(WindowAndroid window, int resultCode,
- ContentResolver contentResolver, Intent data) {
- // Do nothing.
- }
- };
-
- mTab.getWindowAndroid().showIntent(
- appData.detailsIntent(), emptyCallback, R.string.low_memory_error);
+ mTab.getWindowAndroid().showIntent(appData.detailsIntent(), null, null);
}
@CalledByNative
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698