Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1660)

Issue 913553002: NaCl: Update revision in DEPS, 2363d1a -> 66f4b73 (Closed)

Created:
5 years, 10 months ago by Mark Seaborn
Modified:
5 years, 10 months ago
Reviewers:
JF
CC:
chromium-reviews, native-client-reviews_googlegroups.com, teravest
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NaCl: Update revision in DEPS, 2363d1a -> 66f4b73 This pulls in the following Native Client changes: 6c11549: (mseaborn@chromium.org) Add IRT interface for PNaCl's sandboxed linker to use to talk to Chromium 9fff96b: (teravest@chromium.org) NaCl: Remove use of NACL_BUILD_* in common.gypi. 76d6d4b: (mseaborn@chromium.org) PNaCl: Update Binutils revision in pnacl/COMPONENT_REVISIONS: use new IRT interface a3e1e94: (jfb@chromium.org) Delete Windows time code ea0a853: (mseaborn@chromium.org) Cleanup: Move declaration of NaClDebugExceptionHandlerRun() to src/public/ 3fa058c: (mseaborn@chromium.org) Cleanup: Make nacl_desc required rather than optional in chrome_main.h 66f4b73: (mseaborn@chromium.org) Cleanup: Remove unused NaClBootstrapChannelErrorReporter and GetCrashLogOutput() BUG=none TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_compile,linux_nacl_sdk_build Committed: https://crrev.com/8f6e4a1074aa5d83a6873a5f26c237f197ec9161 Cr-Commit-Position: refs/heads/master@{#315389}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Mark Seaborn
5 years, 10 months ago (2015-02-09 18:22:39 UTC) #2
JF
lgtm if this fixes the previous DEPS roll revert: https://codereview.chromium.org/905043002/
5 years, 10 months ago (2015-02-09 18:40:45 UTC) #3
Mark Seaborn
On 2015/02/09 18:40:45, JF wrote: > lgtm if this fixes the previous DEPS roll revert: ...
5 years, 10 months ago (2015-02-09 20:48:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913553002/1
5 years, 10 months ago (2015-02-09 20:50:44 UTC) #6
JF
On 2015/02/09 20:48:59, Mark Seaborn wrote: > On 2015/02/09 18:40:45, JF wrote: > > lgtm ...
5 years, 10 months ago (2015-02-09 20:56:23 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-09 21:01:33 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 21:02:37 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f6e4a1074aa5d83a6873a5f26c237f197ec9161
Cr-Commit-Position: refs/heads/master@{#315389}

Powered by Google App Engine
This is Rietveld 408576698