Remoting: Add missing Gyp dependency on the "prep_toolchain" target

Remoting: Add missing Gyp dependency on the "prep_toolchain" target

BUG=456902
TEST=none

Committed: https://crrev.com/980d6dc4c5e87ac44de166b3dcc50fb512c400e0
Cr-Commit-Position: refs/heads/master@{#315380}

[Mark Seaborn, 2015-02-09 19:34:36]

mseaborn@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[Jamie, 2015-02-09 19:50:40]

lgtm

[Mark Seaborn, 2015-02-09 19:54:54]

The CQ bit was checked by mseaborn@chromium.org

[commit-bot: I haz the power, 2015-02-09 19:55:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/893343003/1

[commit-bot: I haz the power, 2015-02-09 20:43:31]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-02-09 20:44:11]

Patchset 1 (id:??) landed as
https://crrev.com/980d6dc4c5e87ac44de166b3dcc50fb512c400e0
Cr-Commit-Position: refs/heads/master@{#315380}

[Łukasz Anforowicz, 2015-02-09 20:57:07]

lukasza@chromium.org changed reviewers:
+ lukasza@chromium.org

[Łukasz Anforowicz, 2015-02-09 20:57:07]

Sorry for sending my comments after this has already landed :-(.  I have one
(hopefully constructive) comment about the changes + one question - please see
below.

-Lukasz

https://codereview.chromium.org/893343003/diff/1/remoting/remoting_key_tester...
File remoting/remoting_key_tester.gypi (right):

https://codereview.chromium.org/893343003/diff/1/remoting/remoting_key_tester...
remoting/remoting_key_tester.gypi:99: # TODO(mseaborn): Remove need for this
(https://crbug.com/456902).
Mark, do you also want/need a similar TODO comment in remoting/remoting_nacl.gyp
(which also lists prep_toolchain as a dependency)?

BTW: My apologies for missing this dependency.  Are there some pre-check-in
steps that I should have done (that would have caught the missing dependency
before landing crrev.com/884703006)?

[Mark Seaborn, 2015-02-17 22:56:35]

https://codereview.chromium.org/893343003/diff/1/remoting/remoting_key_tester...
File remoting/remoting_key_tester.gypi (right):

https://codereview.chromium.org/893343003/diff/1/remoting/remoting_key_tester...
remoting/remoting_key_tester.gypi:99: # TODO(mseaborn): Remove need for this
(https://crbug.com/456902).
On 2015/02/09 20:57:07, lukasza wrote:
> Mark, do you also want/need a similar TODO comment in
remoting/remoting_nacl.gyp
> (which also lists prep_toolchain as a dependency)?

I thought about doing that, but since ncbray is actively working on removing the
need for this (https://crbug.com/456902), I didn't think it would be worth
adding comments to other locations.  Hopefully the fix will be committed in
Chromium by tomorrow.

> BTW: My apologies for missing this dependency.  Are there some pre-check-in
> steps that I should have done (that would have caught the missing dependency
> before landing crrev.com/884703006)?

No worries.  We were only catching this by manual review before, but ncbray's
cleanup will remove the need for that.