Refactor X64 movq assembler instruction

Refactor X64 movq assembler instruction

R=verwaest@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=18216

[haitao.feng, 2013-11-27 12:08:38]

Hi Toon,

PTAL. I realized I could use template to distinguish x64 and x32. If this is
towards the right direction, I will use this technique to handle all the X64
assembler instructions.

I am OK to change move to movp but I think move is a better name, the next step
is to replace most of the movq occurrence with move (the occurrences needs to be
replaced by movl in the x32 port).

Thanks
-Haitao

[Toon Verwaest, 2013-11-27 13:35:03]

I like it. LGTM (with a nit).

https://codereview.chromium.org/91333002/diff/1/src/x64/assembler-x64.h
File src/x64/assembler-x64.h (right):

https://codereview.chromium.org/91333002/diff/1/src/x64/assembler-x64.h#newco...
src/x64/assembler-x64.h:1681: void moveInternal(Register dst, const Operand&
src);
Rename to MoveInternal.

[haitao.feng, 2013-11-28 03:15:29]

Comments addressed. moveInternal is renamed to emit_mov, and move is renamed to
mov as mov is the same name in the IA32 assembler. Magic number 4, 8 is replaced
to kInt32Size and KInt64Size.

By using this technique (adding new architecture-dependent instructions (such as
mov) and using them most of the time), we should be able to deal with all the
difference between X64 and X32. Toon, thanks for the recommendation, I agree
this is better than the macro assembler layer.

[haitao.feng, 2013-11-28 07:46:43]

> I agree this is better than the macro assembler layer.
Completed the refactoring of movq by using template, PTAL.

[Toon Verwaest, 2013-11-28 10:19:30]

I like it. LGTM.

https://codereview.chromium.org/91333002/diff/40001/src/x64/assembler-x64.h
File src/x64/assembler-x64.h (right):

https://codereview.chromium.org/91333002/diff/40001/src/x64/assembler-x64.h#n...
src/x64/assembler-x64.h:681: #undef DECLARE_INSTRUCTION
Currently this seems like overkill, but I presume you'll soon add other
instructions to the list above as well?

[haitao.feng, 2013-11-28 12:14:41]

Yes, I need to handle all the instructions listed in
https://github.com/fenghaitao/v8/blob/x32/tools/generate-x32-sources.py#L143.

[haitao.feng, 2013-12-02 12:31:34]

Use the name "movp" as you have suggested.

[haitao.feng, 2013-12-03 03:49:55]

Committed patchset #4 manually as r18216 (presubmit successful).