Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(20)

Issue 913273004: [OBSOLETE] De-flake the websocket/close.html layout test (Closed)

Created:
3 years, 8 months ago by Adam Rice
Modified:
1 year ago
Reviewers:
yhirano
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

De-flake the websocket/close.html layout test Also clean it up to share code with workers/close.html and use modern layout test style. BUG=457273

Patch Set 1 #

Patch Set 2 : Use Promises and improve failure behaviour. #

Total comments: 8

Patch Set 3 : Make function indentation consistent. #

Patch Set 4 : Rebase. #

Patch Set 5 : Hack around Mac timeouts. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+436 lines, -624 lines) Patch
M LayoutTests/http/tests/websocket/close.html View 1 2 3 4 1 chunk +5 lines, -200 lines 0 comments Download
M LayoutTests/http/tests/websocket/close-expected.txt View 1 1 chunk +53 lines, -79 lines 0 comments Download
M LayoutTests/http/tests/websocket/close_wsh.py View 1 2 chunks +14 lines, -10 lines 0 comments Download
A LayoutTests/http/tests/websocket/resources/close-common.js View 1 2 1 chunk +258 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/websocket/resources/mac-dropped-wakeup-workaround.js View 1 2 3 4 1 chunk +12 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/websocket/workers/close.html View 1 chunk +2 lines, -30 lines 0 comments Download
M LayoutTests/http/tests/websocket/workers/close-expected.txt View 1 2 3 4 1 chunk +90 lines, -88 lines 0 comments Download
M LayoutTests/http/tests/websocket/workers/resources/close.js View 1 2 3 4 1 chunk +2 lines, -217 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
yhirano
https://codereview.chromium.org/913273004/diff/20001/LayoutTests/http/tests/websocket/resources/close-common.js File LayoutTests/http/tests/websocket/resources/close-common.js (right): https://codereview.chromium.org/913273004/diff/20001/LayoutTests/http/tests/websocket/resources/close-common.js#newcode29 LayoutTests/http/tests/websocket/resources/close-common.js:29: return function () { Please be consistent whether you ...
3 years, 7 months ago (2015-02-27 06:26:44 UTC) #2
Adam Rice
Thank you for the review. https://codereview.chromium.org/913273004/diff/20001/LayoutTests/http/tests/websocket/resources/close-common.js File LayoutTests/http/tests/websocket/resources/close-common.js (right): https://codereview.chromium.org/913273004/diff/20001/LayoutTests/http/tests/websocket/resources/close-common.js#newcode29 LayoutTests/http/tests/websocket/resources/close-common.js:29: return function () { ...
3 years, 7 months ago (2015-02-27 09:34:28 UTC) #3
yhirano
lgtm
3 years, 7 months ago (2015-03-02 02:23:30 UTC) #4
yhirano
2 years, 7 months ago (2016-03-07 22:16:38 UTC) #6
Removing myself from the reviewers list.

Powered by Google App Engine
This is Rietveld 408576698