Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 913273004: [OBSOLETE] De-flake the websocket/close.html layout test (Closed)

Created:
2 years, 11 months ago by Adam Rice
Modified:
3 months, 3 weeks ago
Reviewers:
yhirano
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

De-flake the websocket/close.html layout test Also clean it up to share code with workers/close.html and use modern layout test style. BUG=457273

Patch Set 1 #

Patch Set 2 : Use Promises and improve failure behaviour. #

Total comments: 8

Patch Set 3 : Make function indentation consistent. #

Patch Set 4 : Rebase. #

Patch Set 5 : Hack around Mac timeouts. #

Messages

Total messages: 6 (2 generated)
yhirano
https://codereview.chromium.org/913273004/diff/20001/LayoutTests/http/tests/websocket/resources/close-common.js File LayoutTests/http/tests/websocket/resources/close-common.js (right): https://codereview.chromium.org/913273004/diff/20001/LayoutTests/http/tests/websocket/resources/close-common.js#newcode29 LayoutTests/http/tests/websocket/resources/close-common.js:29: return function () { Please be consistent whether you ...
2 years, 10 months ago (2015-02-27 06:26:44 UTC) #2
Adam Rice
Thank you for the review. https://codereview.chromium.org/913273004/diff/20001/LayoutTests/http/tests/websocket/resources/close-common.js File LayoutTests/http/tests/websocket/resources/close-common.js (right): https://codereview.chromium.org/913273004/diff/20001/LayoutTests/http/tests/websocket/resources/close-common.js#newcode29 LayoutTests/http/tests/websocket/resources/close-common.js:29: return function () { ...
2 years, 10 months ago (2015-02-27 09:34:28 UTC) #3
yhirano
lgtm
2 years, 10 months ago (2015-03-02 02:23:30 UTC) #4
yhirano
1 year, 10 months ago (2016-03-07 22:16:38 UTC) #6
Removing myself from the reviewers list.

Powered by Google App Engine
This is Rietveld 0eb02b776