Issue 913223008: Add FileReaderInterface::ReadExactly() and FileSeekerInterface::SeekSet()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 913223008: Add FileReaderInterface::ReadExactly() and FileSeekerInterface::SeekSet() (Closed)

Created:
5 years, 10 months ago by Mark Mentovai

Modified:
5 years, 10 months ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

Add FileReaderInterface::ReadExactly() and FileSeekerInterface::SeekSet(). These methods perform common error checking. TEST=util_test StringFile.* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/89ca2fbba75120b827df555f947d508b54d5be47

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+105 lines, -2 lines)			Patch
M	util/file/file_reader.h	View		2 chunks	+10 lines, -1 line	0 comments	Download
M	util/file/file_reader.cc	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	util/file/file_seeker.h	View		1 chunk	+15 lines, -0 lines	0 comments	Download
A	util/file/file_seeker.cc	View	1	1 chunk	+37 lines, -0 lines	0 comments	Download
M	util/file/file_writer.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	util/file/string_file_test.cc	View		2 chunks	+27 lines, -0 lines	0 comments	Download
M	util/util.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 6 (3 generated)

Mark Mentovai

5 years, 10 months ago (2015-02-18 23:22:43 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
89ca2fbba75120b827df555f947d508b54d5be47 (presubmit successful).