Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Side by Side Diff: util/file/file_reader.cc

Issue 913223008: Add FileReaderInterface::ReadExactly() and FileSeekerInterface::SeekSet() (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « util/file/file_reader.h ('k') | util/file/file_seeker.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Crashpad Authors. All rights reserved. 1 // Copyright 2015 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "util/file/file_reader.h" 15 #include "util/file/file_reader.h"
16 16
17 #include "base/logging.h" 17 #include "base/logging.h"
18 #include "base/numerics/safe_conversions.h" 18 #include "base/numerics/safe_conversions.h"
19 19
20 namespace crashpad { 20 namespace crashpad {
21 21
22 bool FileReaderInterface::ReadExactly(void* data, size_t size) {
23 ssize_t expect = base::checked_cast<ssize_t>(size);
24 ssize_t rv = Read(data, size);
25 if (rv < 0) {
26 // Read() will have logged its own error.
27 return false;
28 } else if (rv != expect) {
29 LOG(ERROR) << "ReadExactly(): expected " << expect << ", observed " << rv;
30 return false;
31 }
32
33 return true;
34 }
35
22 WeakFileHandleFileReader::WeakFileHandleFileReader(FileHandle file_handle) 36 WeakFileHandleFileReader::WeakFileHandleFileReader(FileHandle file_handle)
23 : file_handle_(file_handle) { 37 : file_handle_(file_handle) {
24 } 38 }
25 39
26 WeakFileHandleFileReader::~WeakFileHandleFileReader() { 40 WeakFileHandleFileReader::~WeakFileHandleFileReader() {
27 } 41 }
28 42
29 ssize_t WeakFileHandleFileReader::Read(void* data, size_t size) { 43 ssize_t WeakFileHandleFileReader::Read(void* data, size_t size) {
30 DCHECK_NE(file_handle_, kInvalidFileHandle); 44 DCHECK_NE(file_handle_, kInvalidFileHandle);
31 45
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 DCHECK(file_.is_valid()); 93 DCHECK(file_.is_valid());
80 return weak_file_handle_file_reader_.Read(data, size); 94 return weak_file_handle_file_reader_.Read(data, size);
81 } 95 }
82 96
83 FileOffset FileReader::Seek(FileOffset offset, int whence) { 97 FileOffset FileReader::Seek(FileOffset offset, int whence) {
84 DCHECK(file_.is_valid()); 98 DCHECK(file_.is_valid());
85 return weak_file_handle_file_reader_.Seek(offset, whence); 99 return weak_file_handle_file_reader_.Seek(offset, whence);
86 } 100 }
87 101
88 } // namespace crashpad 102 } // namespace crashpad
OLDNEW
« no previous file with comments | « util/file/file_reader.h ('k') | util/file/file_seeker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698