Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 913183006: Use BITMAPINFOHEADER from capture capability enumeration when using MJPG (Closed)

Created:
5 years, 10 months ago by perkj_chrome
Modified:
5 years, 10 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

This cl change so that the if a capturer is started using MJPEG, the BITMAPINFOHEADER the capture device report that it supports during capability enumeration is used. BUG=457239 Committed: https://crrev.com/c8d4c771a1df301f83a5b323a2a201d1296ba44b Cr-Commit-Position: refs/heads/master@{#316223}

Patch Set 1 #

Patch Set 2 : Changed so that the SinkInputBit now uses the BITMAPINFOHEADER from capabilities enumeration. #

Total comments: 2

Patch Set 3 : Addressed a nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -47 lines) Patch
M media/video/capture/win/capability_list_win.h View 1 2 2 chunks +18 lines, -4 lines 0 comments Download
M media/video/capture/win/capability_list_win.cc View 1 1 chunk +7 lines, -6 lines 0 comments Download
M media/video/capture/win/sink_filter_win.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M media/video/capture/win/sink_filter_win.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M media/video/capture/win/sink_input_pin_win.h View 1 2 chunks +6 lines, -2 lines 0 comments Download
M media/video/capture/win/sink_input_pin_win.cc View 1 5 chunks +28 lines, -24 lines 0 comments Download
M media/video/capture/win/video_capture_device_win.cc View 1 4 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
perkj_chrome
Please?
5 years, 10 months ago (2015-02-12 15:26:28 UTC) #2
perkj_chrome
PTAL
5 years, 10 months ago (2015-02-13 09:16:14 UTC) #3
tommi (sloooow) - chröme
lgtm https://codereview.chromium.org/913183006/diff/20001/media/video/capture/win/capability_list_win.h File media/video/capture/win/capability_list_win.h (right): https://codereview.chromium.org/913183006/diff/20001/media/video/capture/win/capability_list_win.h#newcode23 media/video/capture/win/capability_list_win.h:23: // Used by the DirectShow implementation VideoCaptureDeviceWin. Used ...
5 years, 10 months ago (2015-02-13 14:50:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/913183006/40001
5 years, 10 months ago (2015-02-13 15:02:59 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-13 16:22:03 UTC) #8
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/c8d4c771a1df301f83a5b323a2a201d1296ba44b Cr-Commit-Position: refs/heads/master@{#316223}
5 years, 10 months ago (2015-02-13 16:22:51 UTC) #9
Nico
This doesn't build on the clang/win bot: FAILED: ninja -t msvc -e environment.x64 -- "..\..\third_party/llvm-build/Release+Asserts/bin/clang-cl" ...
5 years, 10 months ago (2015-02-13 19:34:48 UTC) #10
Nico
5 years, 10 months ago (2015-02-13 19:40:40 UTC) #12
Message was sent while issue was closed.
…actually, I'll fix this.  https://codereview.chromium.org/917183003

Powered by Google App Engine
This is Rietveld 408576698