Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Issue 917183003: clang/win: Fix compile error. (Closed)

Created:
5 years, 10 months ago by Nico
Modified:
5 years, 10 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang/win: Fix compile error. Const member variables must be set in constructors. BUG=82385 TBR=perkj Committed: https://chromium.googlesource.com/chromium/src/+/546fd7573148f233d37a2609931e70789d741786

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/video/capture/win/capability_list_win.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Nico
First to stamp wins!
5 years, 10 months ago (2015-02-13 19:40:56 UTC) #2
Nico
tbr'ing to get our bots green
5 years, 10 months ago (2015-02-13 19:52:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/917183003/1
5 years, 10 months ago (2015-02-13 19:53:50 UTC) #5
commit-bot: I haz the power
Failed to apply the patch.
5 years, 10 months ago (2015-02-13 20:38:42 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/546fd7573148f233d37a2609931e70789d741786 Cr-Commit-Position: refs/heads/master@{#316281}
5 years, 10 months ago (2015-02-13 20:38:59 UTC) #9
Nico
Committed patchset #1 (id:1) manually as 546fd7573148f233d37a2609931e70789d741786 (presubmit successful).
5 years, 10 months ago (2015-02-13 20:39:06 UTC) #10
perkj_chrome
5 years, 10 months ago (2015-02-16 08:01:09 UTC) #11
Message was sent while issue was closed.
sorry for breaking.

lgtm

Powered by Google App Engine
This is Rietveld 408576698