Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 91273002: Improve platform support indications for policy documentation. (Closed)

Created:
7 years ago by Joao da Silva
Modified:
7 years ago
Reviewers:
pastarmovj, Jói
CC:
grit-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/grit-i18n.git@master
Visibility:
Public.

Description

Improve platform support indications for policy documentation. The generated policy documentation indicates example values and preferences paths. This change only shows the data relevant for the platforms where the policy is actually supported. BUG=None

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -41 lines) Patch
M grit/format/policy_templates/policy_template_generator.py View 1 chunk +1 line, -2 lines 0 comments Download
M grit/format/policy_templates/writers/doc_writer.py View 5 chunks +69 lines, -39 lines 2 comments Download
M grit/format/policy_templates/writers/template_writer.py View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Joao da Silva
Just a cosmetic cleanup, PTAL. Thanks!
7 years ago (2013-11-27 11:11:11 UTC) #1
pastarmovj
LGTM but I don't have Python readability so I don't know if it's enough to ...
7 years ago (2013-11-27 12:22:36 UTC) #2
Joao da Silva
Lambdas are fine: http://google-styleguide.googlecode.com/svn/trunk/pyguide.html#Lambda_Functions I'll ping Jói about readability, but I don't think it's needed.
7 years ago (2013-11-27 12:26:03 UTC) #3
Jói
LGTM with a tiny nit. https://codereview.chromium.org/91273002/diff/1/grit/format/policy_templates/writers/doc_writer.py File grit/format/policy_templates/writers/doc_writer.py (right): https://codereview.chromium.org/91273002/diff/1/grit/format/policy_templates/writers/doc_writer.py#newcode648 grit/format/policy_templates/writers/doc_writer.py:648: 'string': ' (REG_SZ)', I'd ...
7 years ago (2013-11-27 12:44:44 UTC) #4
Joao da Silva
7 years ago (2013-11-27 13:03:22 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/91273002/diff/1/grit/format/policy_templates/...
File grit/format/policy_templates/writers/doc_writer.py (right):

https://codereview.chromium.org/91273002/diff/1/grit/format/policy_templates/...
grit/format/policy_templates/writers/doc_writer.py:648: 'string': ' (REG_SZ)',
On 2013/11/27 12:44:44, Jói wrote:
> I'd rather see these without a space and without the surrounding parenthesis,
as
> they can be added when you format the string for Windows on line 464.

Done; note that this CL has been closed and uploaded again as
https://codereview.chromium.org/91233003/

Powered by Google App Engine
This is Rietveld 408576698