Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 912423002: Roll ANGLE 592ab9dd9..38832d179d. (Closed)

Created:
5 years, 10 months ago by Jamie Madill
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll ANGLE 592ab9dd9..38832d179d. https://chromium.googlesource.com/angle/angle/+log/592ab9dd9..38832d179d BUG=450257, 447419, 452587, 453543 Committed: https://crrev.com/3d2f2ff2b1527148d12cd92177951516ae9d1ede Cr-Commit-Position: refs/heads/master@{#315862}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Jamie Madill
PTAL. Windows failure unrelated, retrying.
5 years, 10 months ago (2015-02-11 21:30:18 UTC) #2
bajones
lgtm
5 years, 10 months ago (2015-02-11 22:22:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/912423002/1
5 years, 10 months ago (2015-02-11 23:06:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-11 23:13:06 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3d2f2ff2b1527148d12cd92177951516ae9d1ede Cr-Commit-Position: refs/heads/master@{#315862}
5 years, 10 months ago (2015-02-11 23:14:01 UTC) #7
waffles
5 years, 10 months ago (2015-02-12 00:07:50 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/889653006/ by waffles@chromium.org.

The reason for reverting is: Breaks Win8 GN build:
http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/4638

FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc.exe
"E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86/cl.exe" /nologo
/showIncludes /FC
@obj/third_party/angle/src/libANGLE/renderer/d3d/libANGLE.ProgramD3D.obj.rsp /c
../../third_party/angle/src/libANGLE/renderer/d3d/ProgramD3D.cpp
/Foobj/third_party/angle/src/libANGLE/renderer/d3d/libANGLE.ProgramD3D.obj
/Fdobj/third_party/angle/libANGLE_cc.pdb
e:\b\depot_tools\win_toolchain\vs2013_files\vc\include\concrt.h(313) : error
C2220: warning treated as error - no 'object' file generated
e:\b\depot_tools\win_toolchain\vs2013_files\vc\include\concrt.h(313) : warning
C4530: C++ exception handler used, but unwind semantics are not enabled. Specify
/EHsc.

Powered by Google App Engine
This is Rietveld 408576698