Issue 988: Compile time error missing for const class / non-final instance variables

Issue 988: Compile time error missing for const class / non-final instance variables
http://code.google.com/p/dart/issues/detail?id=988
7.5.3: It is a compile-time error if a constant constructor is declared by a class that has a non-final instance variable.
       The above refers to both locally declared and inherited instance variables.
R=mmendez,zundel
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=3108

[mmendez, 2012-01-09 16:21:27]

lgtm with nits.

http://codereview.chromium.org/9122015/diff/1001/compiler/java/com/google/dar...
File compiler/java/com/google/dart/compiler/resolver/Resolver.java (right):

http://codereview.chromium.org/9122015/diff/1001/compiler/java/com/google/dar...
compiler/java/com/google/dart/compiler/resolver/Resolver.java:258:
constVerifyMembers(classElement.getMembers(), classElement, classElement);
Nit: could just handle current class along with super as part of the loop.

http://codereview.chromium.org/9122015/diff/1001/compiler/java/com/google/dar...
compiler/java/com/google/dart/compiler/resolver/Resolver.java:313: DartNode
errorNode = ((FieldElement) element).getSetter() == null ? element.getNode()
Nit: extract the element as field into a local variable to make the code more
readable.

http://codereview.chromium.org/9122015/diff/1001/compiler/javatests/com/googl...
File
compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java
(right):

http://codereview.chromium.org/9122015/diff/1001/compiler/javatests/com/googl...
compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java:901:
"// filler filler filler filler filler filler filler filler filler filler",
Not sure what this filler stuff is about.  Please remove if it was a left over.

[codefu, 2012-01-09 16:42:04]

http://codereview.chromium.org/9122015/diff/1001/compiler/javatests/com/googl...
File
compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java
(right):

http://codereview.chromium.org/9122015/diff/1001/compiler/javatests/com/googl...
compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java:901:
"// filler filler filler filler filler filler filler filler filler filler",
On 2012/01/09 16:21:27, mmendez wrote:
> Not sure what this filler stuff is about.  Please remove if it was a left
over.

Copy and paste from above example. Will remove.

[zundel, 2012-01-09 17:10:00]

lgtm

http://codereview.chromium.org/9122015/diff/5003/compiler/java/com/google/dar...
File compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java
(right):

http://codereview.chromium.org/9122015/diff/5003/compiler/java/com/google/dar...
compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java:45:
CONST_CLASS_WITH_INHERITED_NONFINAL_FIELDS("Const class %s cannot have
non-final, inherited field %s from class %s"),
nit, 

Konstantin and I were talking about this on Friday.  We should standardize on
whether we want to quote identifier names, and whether or not to use a single or
double quote.

[codefu, 2012-01-09 17:57:08]

http://codereview.chromium.org/9122015/diff/5003/compiler/java/com/google/dar...
File compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java
(right):

http://codereview.chromium.org/9122015/diff/5003/compiler/java/com/google/dar...
compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java:45:
CONST_CLASS_WITH_INHERITED_NONFINAL_FIELDS("Const class %s cannot have
non-final, inherited field %s from class %s"),
On 2012/01/09 17:10:00, zundel wrote:
> nit, 
> 
> Konstantin and I were talking about this on Friday.  We should standardize on
> whether we want to quote identifier names, and whether or not to use a single
or
> double quote.

I'm fine with single quoted identifiers.  Could do that in a batch commit later.