compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java - Issue 9122015: Issue 988: Compile time error missing for const class / non-final instance variables

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java

Issue 9122015: Issue 988: Compile time error missing for const class / non-final instance variables (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Nits Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/resolver/Resolver.java ('k') | compiler/javatests/com/google/dart/compiler/backend/js/JsFieldAccessOptTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java

diff --git a/compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java b/compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java

index 98c060b3236028e2065caf5cefa275421fa01b0b..eda8d0cdcfed093d8800e1a227e19a46f6047ea3 100644

--- a/compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java

+++ b/compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java

@@ -41,7 +41,9 @@ public enum ResolverErrorCode implements ErrorCode {

CONSTRUCTOR_CANNOT_BE_ABSTRACT("A constructor cannot be asbstract"),

CONSTRUCTOR_CANNOT_BE_STATIC("A constructor cannot be static"),

CONSTRUCTOR_CANNOT_HAVE_RETURN_TYPE("Generative constructors cannot have return type"),

- CONST_AND_NONCONST_CONSTRUCTOR("cont reference to non-const constructor."),

+ CONST_AND_NONCONST_CONSTRUCTOR("Cannot reference to non-const constructor."),

+ CONST_CLASS_WITH_INHERITED_NONFINAL_FIELDS("Const class %s cannot have non-final, inherited field %s from class %s"),

zundel 2012/01/09 17:10:00 nit, Konstantin and I were talking about this on

codefu 2012/01/09 17:57:08 I'm fine with single quoted identifiers. Could do

+ CONST_CLASS_WITH_NONFINAL_FIELDS("Const class %s cannot have non-final field %s"),

CONST_CONSTRUCTOR_CANNOT_HAVE_BODY("A const constructor cannot have a body"),

CONST_CONSTRUCTOR_MUST_CALL_CONST_SUPER("const constructor must call const super constructor"),

CONSTANTS_MUST_BE_INITIALIZED("constants must be initialized"),