Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 9121008: Merge 104252 - Source/WebCore: IndexedDB: fix cursor prefetch crash (Closed)

Created:
8 years, 11 months ago by dgrogan
Modified:
8 years, 11 months ago
Reviewers:
dgrogan
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/963/
Visibility:
Public.

Description

Merge 104252 - Source/WebCore: IndexedDB: fix cursor prefetch crash http://crbug.com/108071 https://bugs.webkit.org/show_bug.cgi?id=75596 Reviewed by Tony Chang. Test: storage/indexeddb/prefetch-bugfix-108071.html Note: DumpRenderTree doesn't exercise the bug, it only occurs in multi-process chromium. The layout test will soon be run as a chromium ui test: http://codereview.chromium.org/9108004 * storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl): (WebCore::IDBCursorBackendImpl::~IDBCursorBackendImpl): Destroy cursors before their objectstores. (WebCore::IDBCursorBackendImpl::prefetchReset): Don't run continue if the cursor is closed. (WebCore::IDBCursorBackendImpl::close): Set a closed flag. * storage/IDBCursorBackendImpl.h: LayoutTests: IndexedDB: fix cursor prefetch crash https://bugs.webkit.org/show_bug.cgi?id=75596 Reviewed by Tony Chang. * storage/indexeddb/prefetch-bugfix-108071-expected.txt: Added. * storage/indexeddb/prefetch-bugfix-108071.html: Added. TBR=dgrogan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104310

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, --2 lines) Patch
A + LayoutTests/storage/indexeddb/prefetch-bugfix-108071.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/storage/indexeddb/prefetch-bugfix-108071-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/storage/IDBCursorBackendImpl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/WebCore/storage/IDBCursorBackendImpl.cpp View 4 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
dgrogan
8 years, 11 months ago (2012-01-06 19:53:43 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698