Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 9108004: IndexedDB: Run cursor-prefetch webkit layout test as ui test. (Closed)

Created:
8 years, 11 months ago by dgrogan
Modified:
8 years, 11 months ago
Reviewers:
michaeln, jsbell
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

IndexedDB: Run cursor-prefetch webkit layout test as ui test. The test exercises a bug that is only triggered when run in multi-process chromium. The patch in https://bugs.webkit.org/show_bug.cgi?id=75596 has to be committed and rolled before this change can be committed. This ui test will eventually run all of the IDB layout tests. BUG=108071 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117196

Patch Set 1 #

Total comments: 3

Patch Set 2 : address comments; add DEPS change necessary for buildbots #

Total comments: 2

Patch Set 3 : remove extraneous setup method #

Patch Set 4 : sync to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -0 lines) Patch
M DEPS View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A content/browser/in_process_webkit/indexed_db_uitest.cc View 1 2 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
dgrogan
This obviously depends on the webkit patch[1] getting committed and rolled. 1. https://bugs.webkit.org/show_bug.cgi?id=75596
8 years, 11 months ago (2012-01-05 04:41:06 UTC) #1
jsbell
Overall LGTM, just nits. Have you tried with any other layout tests, e.g. some of ...
8 years, 11 months ago (2012-01-05 19:03:55 UTC) #2
dgrogan
On 2012/01/05 19:03:55, jsbell wrote: > Overall LGTM, just nits. > > Have you tried ...
8 years, 11 months ago (2012-01-07 01:06:34 UTC) #3
commit-bot: I haz the power
No LGTM from valid reviewers yet.
8 years, 11 months ago (2012-01-07 02:17:19 UTC) #4
dgrogan
Michael, could you review this? Apparently Josh's LGTMs aren't good anymore. We'll have to nominate ...
8 years, 11 months ago (2012-01-07 04:51:57 UTC) #5
michaeln
LGTM http://codereview.chromium.org/9108004/diff/7002/content/browser/in_process_webkit/indexed_db_uitest.cc File content/browser/in_process_webkit/indexed_db_uitest.cc (right): http://codereview.chromium.org/9108004/diff/7002/content/browser/in_process_webkit/indexed_db_uitest.cc#newcode30 content/browser/in_process_webkit/indexed_db_uitest.cc:30: UILayoutTest::SetUp(); why is this override needed?
8 years, 11 months ago (2012-01-10 21:22:41 UTC) #6
dgrogan
http://codereview.chromium.org/9108004/diff/7002/content/browser/in_process_webkit/indexed_db_uitest.cc File content/browser/in_process_webkit/indexed_db_uitest.cc (right): http://codereview.chromium.org/9108004/diff/7002/content/browser/in_process_webkit/indexed_db_uitest.cc#newcode30 content/browser/in_process_webkit/indexed_db_uitest.cc:30: UILayoutTest::SetUp(); On 2012/01/10 21:22:41, michaeln wrote: > why is ...
8 years, 11 months ago (2012-01-11 08:27:18 UTC) #7
commit-bot: I haz the power
Failed to apply the patch.
8 years, 11 months ago (2012-01-11 08:30:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgrogan@chromium.org/9108004/18001
8 years, 11 months ago (2012-01-11 08:48:19 UTC) #9
commit-bot: I haz the power
8 years, 11 months ago (2012-01-11 10:03:11 UTC) #10
Change committed as 117196

Powered by Google App Engine
This is Rietveld 408576698