Issue 9120011: Use GURL::Replacements to trim query and ref from URL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9120011: Use GURL::Replacements to trim query and ref from URL (Closed)

Created:
8 years, 11 months ago by battre

Modified:
8 years, 11 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Use GURL::Replacements to trim query and ref from URL BUG=108648 TEST=no Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116960

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	chrome/browser/extensions/extension_webrequest_api.cc	View		1 chunk	+5 lines, -3 lines	0 comments	Download

Total messages: 6 (0 generated)

battre

Hi Matt, this is the requested change to GURL::Replacements to trim query parameters and a ...

8 years, 11 months ago (2012-01-06 21:46:02 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/9120011/1

8 years, 11 months ago (2012-01-09 19:54:18 UTC) #3

commit-bot: I haz the power

Try job failure for 9120011-1 (retry) on win_rel for steps "safe_browsing_tests, unit_tests, views_unittests, browser_tests, ui_tests". ...

8 years, 11 months ago (2012-01-09 21:05:56 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/9120011/1

8 years, 11 months ago (2012-01-09 21:50:20 UTC) #5

Change committed as 116960