Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 9120011: Use GURL::Replacements to trim query and ref from URL (Closed)

Created:
7 years ago by battre
Modified:
7 years ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org
Visibility:
Public.

Description

Use GURL::Replacements to trim query and ref from URL BUG=108648 TEST=no Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116960

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/browser/extensions/extension_webrequest_api.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
battre
Hi Matt, this is the requested change to GURL::Replacements to trim query parameters and a ...
7 years ago (2012-01-06 21:46:02 UTC) #1
Matt Perry
lgtm
7 years ago (2012-01-06 22:40:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/9120011/1
7 years ago (2012-01-09 19:54:18 UTC) #3
commit-bot: I haz the power
Try job failure for 9120011-1 (retry) on win_rel for steps "safe_browsing_tests, unit_tests, views_unittests, browser_tests, ui_tests". ...
7 years ago (2012-01-09 21:05:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/9120011/1
7 years ago (2012-01-09 21:50:20 UTC) #5
commit-bot: I haz the power
7 years ago (2012-01-09 23:59:56 UTC) #6
Change committed as 116960

Powered by Google App Engine
This is Rietveld 408576698