Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 911993002: DevTools: [Console] render console stacktraces consistently (Closed)

Created:
5 years, 10 months ago by lushnikov
Modified:
5 years, 10 months ago
Reviewers:
pfeldman
CC:
aandrey+blink_chromium.org, apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, eustas+blink_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, vsevik+blink_chromium.org, yurys+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: [Console] render console stacktraces consistently The patch switches conosle stacktrace rendering to utility method from DOMPresentationUtils. BUG=441734 R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189982

Patch Set 1 #

Patch Set 2 : rebaseline tests #

Patch Set 3 : rebaseline one more test #

Patch Set 4 : rebaseline one more test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -103 lines) Patch
M LayoutTests/http/tests/inspector/console-resource-errors-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/inspector-test.js View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/sources/debugger/async-callstack-network-initiator-expected.txt View 1 2 3 1 chunk +5 lines, -4 lines 0 comments Download
M LayoutTests/inspector/console/console-assert-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/console/console-error-on-call-frame-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/console/console-stack-overflow-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/console/console-trace-arguments-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/console/console-trace-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/console/console-trace-in-eval-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/console/console-uncaught-exception-expected.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/inspector/console/console-uncaught-exception-in-eval-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/console/console-uncaught-promise-expected.txt View 1 2 3 chunks +21 lines, -14 lines 0 comments Download
M LayoutTests/inspector/console/worker-eval-contains-stack-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/console/worker-exception-message-contains-stack-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/sources/debugger/async-callstack-in-console-expected.txt View 1 1 chunk +18 lines, -14 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-uncaught-promise-on-pause-expected.txt View 1 2 chunks +6 lines, -4 lines 0 comments Download
M Source/devtools/front_end/console/ConsoleViewMessage.js View 1 chunk +6 lines, -38 lines 0 comments Download
M Source/devtools/front_end/console/consoleView.css View 2 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
lushnikov
PTAL Screenshot: http://imgur.com/1OiwmF3
5 years, 10 months ago (2015-02-10 19:54:42 UTC) #1
pfeldman
lgtm.
5 years, 10 months ago (2015-02-10 20:05:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/911993002/1
5 years, 10 months ago (2015-02-10 20:06:28 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/50224)
5 years, 10 months ago (2015-02-10 21:42:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/911993002/40001
5 years, 10 months ago (2015-02-11 15:19:21 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/46436)
5 years, 10 months ago (2015-02-11 17:01:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/911993002/60001
5 years, 10 months ago (2015-02-11 17:19:05 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 21:43:10 UTC) #14
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189982

Powered by Google App Engine
This is Rietveld 408576698