Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1607)

Unified Diff: Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 911993002: DevTools: [Console] render console stacktraces consistently (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebaseline one more test Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/console/ConsoleViewMessage.js
diff --git a/Source/devtools/front_end/console/ConsoleViewMessage.js b/Source/devtools/front_end/console/ConsoleViewMessage.js
index b710997daa779f218d028ed8e3e3a728508a3822..23173faf6b910ad6a9e724ab2b5e2a8e4e81a9c5 100644
--- a/Source/devtools/front_end/console/ConsoleViewMessage.js
+++ b/Source/devtools/front_end/console/ConsoleViewMessage.js
@@ -1125,44 +1125,12 @@ WebInspector.ConsoleViewMessage.prototype = {
*/
_populateStackTraceTreeElement: function(parentTreeElement)
{
- /**
- * @param {!Array.<!ConsoleAgent.CallFrame>=} stackTrace
- * @this {WebInspector.ConsoleViewMessage}
- */
- function appendStackTrace(stackTrace)
- {
- if (!stackTrace)
- return;
-
- for (var i = 0; i < stackTrace.length; i++) {
- var frame = stackTrace[i];
-
- var content = createElementWithClass("div", "stacktrace-entry");
- var functionName = WebInspector.beautifyFunctionName(frame.functionName);
- if (frame.scriptId) {
- var urlElement = this._linkifyCallFrame(frame);
- if (!urlElement)
- continue;
- content.appendChild(urlElement);
- content.createTextChild(" ");
- }
-
- content.createChild("span", "console-message-text source-code").textContent = functionName;
- parentTreeElement.appendChild(new TreeElement(content));
- }
- }
-
- appendStackTrace.call(this, this._message.stackTrace);
-
- for (var asyncTrace = this._message.asyncStackTrace; asyncTrace; asyncTrace = asyncTrace.asyncStackTrace) {
- if (!asyncTrace.callFrames || !asyncTrace.callFrames.length)
- break;
- var content = createElementWithClass("div", "stacktrace-entry");
- var description = WebInspector.asyncStackTraceLabel(asyncTrace.description);
- content.createChild("span", "console-message-text source-code console-async-trace-text").textContent = description;
- parentTreeElement.appendChild(new TreeElement(content));
- appendStackTrace.call(this, asyncTrace.callFrames);
- }
+ var target = this._target();
+ if (!target)
+ return;
+ var content = WebInspector.DOMPresentationUtils.buildStackTracePreviewContents(target,
+ this._linkifier, this._message.stackTrace, this._message.asyncStackTrace);
+ parentTreeElement.appendChild(new TreeElement(content));
},
resetIncrementRepeatCount: function()

Powered by Google App Engine
This is Rietveld 408576698