Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 911923002: Fix missing "..." in the supervised user import dialog. (Closed)

Created:
5 years, 10 months ago by Marc Treib
Modified:
5 years, 10 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, tfarina, michaelpg+watch-options_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix missing "..." in the supervised user import dialog. This was due to incorrect usage of css flex. BUG=457178 Committed: https://crrev.com/731949241f86670406bbac6e54f5336036716cfa Cr-Commit-Position: refs/heads/master@{#315956}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M chrome/browser/resources/options/supervised_user_import.css View 1 chunk +9 lines, -1 line 0 comments Download
M chrome/browser/resources/options/supervised_user_list.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Marc Treib
PTAL! I broke this ages ago in https://codereview.chromium.org/403343002, where I simply replaced "-webkit-box-flex" with "flex" ...
5 years, 10 months ago (2015-02-10 17:49:18 UTC) #2
Pam (message me for reviews)
And I, of course, didn't notice the change back then. LGTM. - Pam
5 years, 10 months ago (2015-02-10 18:34:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/911923002/1
5 years, 10 months ago (2015-02-12 08:44:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-12 10:47:16 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 10:48:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/731949241f86670406bbac6e54f5336036716cfa
Cr-Commit-Position: refs/heads/master@{#315956}

Powered by Google App Engine
This is Rietveld 408576698