Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 403343002: Rename "managed (mode|user)" to "supervised user" (part 8) (Closed)

Created:
6 years, 5 months ago by Marc Treib
Modified:
6 years, 4 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, zea+watch_chromium.org, tfarina, yoshiki+watch_chromium.org, haitaol+watch_chromium.org, Patrick Dubroy, rginda+watch_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, tim+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, maniscalco+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Rename "managed (mode|user)" to "supervised user" (part 8) Followup to https://codereview.chromium.org/393343002/ This CL renames JavaScript, HTML, and CSS. Still missing: - ChromeOS-specific resource IDs (strings and images) - The global ENABLE_MANAGED_USERS define TBRing some trivial comment-only changes. TBR=atwilson@chromium.org (c/b/sync) TBR=noms@chromium.org (c/b/profiles) BUG=385113 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286486

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : fix name collision #

Patch Set 4 : rebase #

Patch Set 5 : fix #

Patch Set 6 : fix2 #

Total comments: 20

Patch Set 7 : review comments (and rebase) #

Patch Set 8 : a,b,c... (and rebase, and fix some js presubmit warnings) #

Patch Set 9 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1025 lines, -4185 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/user_selection_screen.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_creation_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_password_browsertest.cc View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_test_base.cc View 1 2 3 4 5 6 7 8 6 chunks +21 lines, -21 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/header_bar.js View 1 2 3 4 5 6 7 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/login/login.js View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/login_common.js View 1 2 3 4 5 6 7 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/login/login_resources.html View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/login_screens.html View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/oobe.js View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screens.html View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/screen_error_message.css View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_error_message.html View 1 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_error_message.js View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.css View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.html View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.js View 1 2 3 4 5 6 4 chunks +15 lines, -13 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.css View 1 1 chunk +0 lines, -551 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.html View 1 1 chunk +0 lines, -158 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.js View 1 1 chunk +0 lines, -1592 lines 0 comments Download
A + chrome/browser/resources/chromeos/login/screen_supervised_user_creation.css View 1 16 chunks +92 lines, -92 lines 0 comments Download
A + chrome/browser/resources/chromeos/login/screen_supervised_user_creation.html View 1 2 3 4 5 6 3 chunks +61 lines, -59 lines 0 comments Download
A + chrome/browser/resources/chromeos/login/screen_supervised_user_creation.js View 1 2 3 4 5 6 7 43 chunks +98 lines, -93 lines 0 comments Download
M chrome/browser/resources/extensions/extensions.css View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/extensions/extensions.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/extensions/extensions.js View 1 2 3 4 5 6 7 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/resources/history/history.js View 1 2 3 4 5 6 9 chunks +24 lines, -23 lines 0 comments Download
M chrome/browser/resources/options/browser_options.js View 1 2 3 4 5 6 7 8 8 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/resources/options/browser_options_profile_list.js View 1 2 3 4 5 6 3 chunks +3 lines, -10 lines 0 comments Download
M chrome/browser/resources/options/manage_profile_overlay.css View 1 2 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/resources/options/manage_profile_overlay.html View 4 chunks +19 lines, -19 lines 0 comments Download
M chrome/browser/resources/options/manage_profile_overlay.js View 1 2 3 4 5 6 7 8 21 chunks +104 lines, -97 lines 0 comments Download
D chrome/browser/resources/options/managed_user_create_confirm.css View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/browser/resources/options/managed_user_create_confirm.html View 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/browser/resources/options/managed_user_create_confirm.js View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -103 lines 0 comments Download
D chrome/browser/resources/options/managed_user_import.css View 1 chunk +0 lines, -72 lines 0 comments Download
D chrome/browser/resources/options/managed_user_import.html View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/resources/options/managed_user_import.js View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -251 lines 0 comments Download
D chrome/browser/resources/options/managed_user_learn_more.css View 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/browser/resources/options/managed_user_learn_more.html View 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/browser/resources/options/managed_user_learn_more.js View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/browser/resources/options/managed_user_list.js View 1 chunk +0 lines, -116 lines 0 comments Download
D chrome/browser/resources/options/managed_user_list_data.js View 1 chunk +0 lines, -152 lines 0 comments Download
M chrome/browser/resources/options/options.html View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/resources/options/options.js View 1 2 3 4 5 6 3 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/resources/options/options_bundle.js View 1 2 3 4 5 6 2 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/resources/options/supervised_user_create_confirm.css View 2 chunks +8 lines, -8 lines 0 comments Download
A + chrome/browser/resources/options/supervised_user_create_confirm.html View 1 1 chunk +8 lines, -8 lines 0 comments Download
A + chrome/browser/resources/options/supervised_user_create_confirm.js View 1 2 3 4 5 6 7 8 6 chunks +20 lines, -20 lines 0 comments Download
A + chrome/browser/resources/options/supervised_user_import.css View 3 chunks +10 lines, -10 lines 0 comments Download
A + chrome/browser/resources/options/supervised_user_import.html View 1 2 3 4 5 6 1 chunk +27 lines, -24 lines 0 comments Download
A + chrome/browser/resources/options/supervised_user_import.js View 1 2 3 4 5 6 7 8 7 chunks +71 lines, -69 lines 0 comments Download
A + chrome/browser/resources/options/supervised_user_learn_more.css View 2 chunks +9 lines, -9 lines 0 comments Download
A + chrome/browser/resources/options/supervised_user_learn_more.html View 1 1 chunk +9 lines, -9 lines 0 comments Download
A + chrome/browser/resources/options/supervised_user_learn_more.js View 1 2 3 4 5 6 7 8 3 chunks +9 lines, -9 lines 0 comments Download
A + chrome/browser/resources/options/supervised_user_list.js View 4 chunks +27 lines, -27 lines 0 comments Download
A + chrome/browser/resources/options/supervised_user_list_data.js View 5 chunks +41 lines, -40 lines 0 comments Download
M chrome/browser/sync/sessions/notification_service_sessions_router.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc View 1 2 3 4 5 6 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc View 1 2 3 4 5 6 6 chunks +48 lines, -48 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/ui_account_tweaks.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/history_ui.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 2 3 4 5 6 7 8 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/options/create_profile_handler.cc View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/manage_profile_browsertest.js View 1 2 21 chunks +97 lines, -94 lines 0 comments Download
M chrome/browser/ui/webui/options/manage_profile_handler.cc View 3 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/options/options_browsertest.js View 1 2 3 4 5 6 7 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/options/supervised_user_create_confirm_handler.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/supervised_user_import_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/supervised_user_import_handler.cc View 4 chunks +17 lines, -13 lines 0 comments Download
M chrome/browser/ui/webui/options/supervised_user_learn_more_handler.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/signin/user_manager_screen_handler.cc View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/chromeos/oobe_webui_browsertest.js View 1 2 3 4 5 1 chunk +6 lines, -6 lines 0 comments Download
M ui/login/account_picker/screen_account_picker.js View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M ui/login/account_picker/user_pod_row.js View 1 2 3 4 5 6 7 6 chunks +7 lines, -8 lines 0 comments Download
M ui/login/display_manager.js View 1 2 3 4 5 6 7 4 chunks +6 lines, -6 lines 0 comments Download
M ui/login/screen_container.css View 1 2 3 4 5 6 7 2 chunks +11 lines, -11 lines 0 comments Download
M ui/webui/resources/js/chromeos/ui_account_tweaks.js View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
Marc Treib
As promised (threatened?), here's the next batch! PTAL
6 years, 5 months ago (2014-07-23 10:54:15 UTC) #1
Pam (message me for reviews)
https://codereview.chromium.org/403343002/diff/160001/chrome/browser/profile_resetter/automatic_profile_resetter_unittest.cc File chrome/browser/profile_resetter/automatic_profile_resetter_unittest.cc (right): https://codereview.chromium.org/403343002/diff/160001/chrome/browser/profile_resetter/automatic_profile_resetter_unittest.cc#newcode1271 chrome/browser/profile_resetter/automatic_profile_resetter_unittest.cc:1271: TEST_F(AutomaticProfileResetterTest, InputSupervisedUserPreferencesCorrect) { This test isn't looking at preferences ...
6 years, 5 months ago (2014-07-23 21:13:39 UTC) #2
Denis Kuznetsov (DE-MUC)
*/chromeos/* lgtm https://chromiumcodereview.appspot.com/403343002/diff/160001/chrome/browser/resources/chromeos/login/login_common.js File chrome/browser/resources/chromeos/login/login_common.js (right): https://chromiumcodereview.appspot.com/403343002/diff/160001/chrome/browser/resources/chromeos/login/login_common.js#newcode160 chrome/browser/resources/chromeos/login/login_common.js:160: * Shows dialog to create a supervised ...
6 years, 5 months ago (2014-07-24 11:37:22 UTC) #3
Marc Treib
https://codereview.chromium.org/403343002/diff/160001/chrome/browser/profile_resetter/automatic_profile_resetter_unittest.cc File chrome/browser/profile_resetter/automatic_profile_resetter_unittest.cc (right): https://codereview.chromium.org/403343002/diff/160001/chrome/browser/profile_resetter/automatic_profile_resetter_unittest.cc#newcode1271 chrome/browser/profile_resetter/automatic_profile_resetter_unittest.cc:1271: TEST_F(AutomaticProfileResetterTest, InputSupervisedUserPreferencesCorrect) { On 2014/07/23 21:13:39, Pam (also PM ...
6 years, 5 months ago (2014-07-24 12:11:54 UTC) #4
Pam (message me for reviews)
lgtm
6 years, 5 months ago (2014-07-24 17:03:16 UTC) #5
Pam (message me for reviews)
https://codereview.chromium.org/403343002/diff/160001/chrome/browser/resources/chromeos/login/screen_supervised_user_creation.js File chrome/browser/resources/chromeos/login/screen_supervised_user_creation.js (right): https://codereview.chromium.org/403343002/diff/160001/chrome/browser/resources/chromeos/login/screen_supervised_user_creation.js#newcode508 chrome/browser/resources/chromeos/login/screen_supervised_user_creation.js:508: 'setDefaultImages', On 2014/07/24 12:11:54, treib wrote: > On 2014/07/23 ...
6 years, 5 months ago (2014-07-24 17:03:28 UTC) #6
Marc Treib
https://codereview.chromium.org/403343002/diff/160001/chrome/browser/resources/chromeos/login/screen_supervised_user_creation.js File chrome/browser/resources/chromeos/login/screen_supervised_user_creation.js (right): https://codereview.chromium.org/403343002/diff/160001/chrome/browser/resources/chromeos/login/screen_supervised_user_creation.js#newcode508 chrome/browser/resources/chromeos/login/screen_supervised_user_creation.js:508: 'setDefaultImages', On 2014/07/24 17:03:27, Pam (also PM for reviews) ...
6 years, 5 months ago (2014-07-25 09:41:28 UTC) #7
Pam (message me for reviews)
The CQ bit was checked by pam@chromium.org
6 years, 5 months ago (2014-07-25 16:59:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/403343002/200001
6 years, 5 months ago (2014-07-25 17:00:42 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-25 19:08:46 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-25 19:13:46 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/82460)
6 years, 5 months ago (2014-07-25 19:13:48 UTC) #12
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 4 months ago (2014-07-29 14:55:10 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/403343002/200001
6 years, 4 months ago (2014-07-29 14:56:09 UTC) #14
Marc Treib
The CQ bit was unchecked by treib@chromium.org
6 years, 4 months ago (2014-07-29 16:58:47 UTC) #15
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 4 months ago (2014-07-30 08:34:42 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/403343002/220001
6 years, 4 months ago (2014-07-30 08:37:25 UTC) #17
commit-bot: I haz the power
6 years, 4 months ago (2014-07-30 11:55:50 UTC) #18
Message was sent while issue was closed. 
Change committed as 286486

Powered by Google App Engine
This is Rietveld 408576698