Issue 91183002: Timeline: do not rely on UpdateLayer & PaintLayer trace events

Issue 91183002: Timeline: do not rely on UpdateLayer & PaintLayer trace events (Closed)

Created:
7 years ago by caseq

Modified:
7 years ago

Reviewers:
pfeldman

CC:
blink-reviews, bemjb+rendering_chromium.org, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, leviw+renderwatch, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, zoltan1, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, Inactive, jchaffraix+rendering, devtools-reviews_chromium.org, arv+blink, aandrey+blink_chromium.org, watchdog-blink-watchlist_google.com, danakj, enne (OOO), nduca

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Timeline: do not rely on UpdateLayer & PaintLayer trace events ... extract layer id from webcore CompositedLayerMapping instrumentation instead. BUG=322207 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162771

Patch Set 1 #

Patch Set 2 : re-upload #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -67 lines)			Patch
M	Source/core/frame/FrameView.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/inspector/InspectorInstrumentation.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/core/inspector/InspectorInstrumentation.cpp	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/core/inspector/InspectorInstrumentation.idl	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/inspector/InspectorTimelineAgent.h	View	3 chunks	+5 lines, -1 line	0 comments	Download
M	Source/core/inspector/InspectorTimelineAgent.cpp	View	3 chunks	+9 lines, -5 lines	0 comments	Download
M	Source/core/inspector/TimelineTraceEventProcessor.h	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	Source/core/inspector/TimelineTraceEventProcessor.cpp	View	4 chunks	+12 lines, -47 lines	0 comments	Download
M	Source/core/rendering/CompositedLayerMapping.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

caseq

This will let us nuke UpdateLayer & PaintLayer from cc/debug/devtools_instrumentation.

7 years ago (2013-11-27 10:13:32 UTC) #1

pfeldman

Please upload the patch. Making a self-review prior to publishing changes is a good practice ...

7 years ago (2013-11-27 11:56:57 UTC) #2

caseq

On 2013/11/27 11:56:57, pfeldman wrote: > Please upload the patch. Making a self-review prior to ...

7 years ago (2013-11-27 12:19:01 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/91183002/20001

7 years ago (2013-11-27 16:05:22 UTC) #6

Message was sent while issue was closed.

Change committed as 162771

Expand Messages | Collapse Messages