Chromium Code Reviews

Issue 911543002: Correctly clean up natives sources on tear down. (Closed)

Created:
5 years, 10 months ago by Yang
Modified:
5 years, 10 months ago
Reviewers:
ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Correctly clean up natives sources on tear down. R=ulan@chromium.org Committed: https://crrev.com/161efc42bf12682616ce4fba99d854935f9148f6 Cr-Commit-Position: refs/heads/master@{#26516}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Stats (+17 lines, -66 lines)
M src/bootstrapper.h View 3 chunks +2 lines, -11 lines 2 comments
M src/bootstrapper.cc View 3 chunks +13 lines, -53 lines 0 comments
M src/serialize.cc View 1 chunk +2 lines, -2 lines 0 comments

Messages

Total messages: 8 (1 generated)
Yang
5 years, 10 months ago (2015-02-09 08:01:56 UTC) #1
ulan
https://codereview.chromium.org/911543002/diff/1/src/bootstrapper.h File src/bootstrapper.h (right): https://codereview.chromium.org/911543002/diff/1/src/bootstrapper.h#newcode150 src/bootstrapper.h:150: NativesExternalStringResource(const char* source, size_t length) Shouldn't the destructor of ...
5 years, 10 months ago (2015-02-09 08:22:52 UTC) #2
Yang
https://codereview.chromium.org/911543002/diff/1/src/bootstrapper.h File src/bootstrapper.h (right): https://codereview.chromium.org/911543002/diff/1/src/bootstrapper.h#newcode150 src/bootstrapper.h:150: NativesExternalStringResource(const char* source, size_t length) On 2015/02/09 08:22:52, ulan ...
5 years, 10 months ago (2015-02-09 08:37:16 UTC) #3
ulan
lgtm
5 years, 10 months ago (2015-02-09 09:00:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/911543002/1
5 years, 10 months ago (2015-02-09 09:03:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-09 09:04:55 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 09:05:09 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/161efc42bf12682616ce4fba99d854935f9148f6
Cr-Commit-Position: refs/heads/master@{#26516}

Powered by Google App Engine