Correctly clean up natives sources on tear down.

Correctly clean up natives sources on tear down.

R=ulan@chromium.org

Committed: https://crrev.com/161efc42bf12682616ce4fba99d854935f9148f6
Cr-Commit-Position: refs/heads/master@{#26516}

[ulan, 2015-02-09 08:22:52]

https://codereview.chromium.org/911543002/diff/1/src/bootstrapper.h
File src/bootstrapper.h (right):

https://codereview.chromium.org/911543002/diff/1/src/bootstrapper.h#newcode150
src/bootstrapper.h:150: NativesExternalStringResource(const char* source, size_t
length)
Shouldn't the destructor of this delete data?

[Yang, 2015-02-09 08:37:16]

https://codereview.chromium.org/911543002/diff/1/src/bootstrapper.h
File src/bootstrapper.h (right):

https://codereview.chromium.org/911543002/diff/1/src/bootstrapper.h#newcode150
src/bootstrapper.h:150: NativesExternalStringResource(const char* source, size_t
length)
On 2015/02/09 08:22:52, ulan wrote:
> Shouldn't the destructor of this delete data?

No. The data is supplied either as an address in the binary (js2c converts the
js files into a .cc file, which is then compiled into the binary) or by the
embedder as external natives blob. In either case they must not be deleted by
V8.

[ulan, 2015-02-09 09:00:05]

lgtm

[Yang, 2015-02-09 09:02:56]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2015-02-09 09:03:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/911543002/1

[commit-bot: I haz the power, 2015-02-09 09:04:55]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-02-09 09:05:09]

Patchset 1 (id:??) landed as
https://crrev.com/161efc42bf12682616ce4fba99d854935f9148f6
Cr-Commit-Position: refs/heads/master@{#26516}