Correctly clean up natives sources on tear down.

src/bootstrapper.h

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_BOOTSTRAPPER_H_
 #define V8_BOOTSTRAPPER_H_
 
 #include "src/factory.h"
 
 namespace v8 {
@@ skipping 80 matching lines @@
 
   // Tells whether bootstrapping is active.
   bool IsActive() const { return nesting_ != 0; }
 
   // Support for thread preemption.
   static int ArchiveSpacePerThread();
   char* ArchiveState(char* to);
   char* RestoreState(char* from);
   void FreeThreadResources();
 
-  // This will allocate a char array that is deleted when V8 is shut down.
-  // It should only be used for strictly finite allocations.
-  char* AllocateAutoDeletedArray(int bytes);
-
   // Used for new context creation.
   bool InstallExtensions(Handle<Context> native_context,
                          v8::ExtensionConfiguration* extensions);
 
   SourceCodeCache* extensions_cache() { return &extensions_cache_; }
 
  private:
   Isolate* isolate_;
   typedef int NestingCounterType;
   NestingCounterType nesting_;
   SourceCodeCache extensions_cache_;
-  // This is for delete, not delete[].
-  List<char*>* delete_these_non_arrays_on_tear_down_;
-  // This is for delete[]
-  List<char*>* delete_these_arrays_on_tear_down_;
 
   friend class BootstrapperActive;
   friend class Isolate;
   friend class NativesExternalStringResource;
 
   explicit Bootstrapper(Isolate* isolate);
 
   static v8::Extension* free_buffer_extension_;
   static v8::Extension* gc_extension_;
   static v8::Extension* externalize_string_extension_;
@@ skipping 18 matching lines @@
  private:
   Bootstrapper* bootstrapper_;
 
   DISALLOW_COPY_AND_ASSIGN(BootstrapperActive);
 };
 
 
 class NativesExternalStringResource FINAL
     : public v8::String::ExternalOneByteStringResource {
  public:
-  NativesExternalStringResource(Bootstrapper* bootstrapper,
-                                const char* source,
-                                size_t length);
+  NativesExternalStringResource(const char* source, size_t length)

[ulan, 2015/02/09 08:22:52]

Shouldn't the destructor of this delete data?

[Yang, 2015/02/09 08:37:16]

No. The data is supplied either as an address in the binary (js2c converts the
js files into a .cc file, which is then compiled into the binary) or by the
embedder as external natives blob. In either case they must not be deleted by
V8.

+      : data_(source), length_(length) {}
   const char* data() const OVERRIDE { return data_; }
   size_t length() const OVERRIDE { return length_; }
 
  private:
   const char* data_;
   size_t length_;
 };
 
 }}  // namespace v8::internal
 
 #endif  // V8_BOOTSTRAPPER_H_