Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 911463003: NaCl cleanup: Move ppb_nacl_private.h into components/nacl/renderer/ (Closed)

Created:
5 years, 10 months ago by Mark Seaborn
Modified:
5 years, 10 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, piman+watch_chromium.org, teravest+watch_chromium.org, raymes+watch_chromium.org, bradnelson+warch_chromium.org, chromium-apps-reviews_chromium.org, native-client-reviews_googlegroups.com, ihf+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NaCl cleanup: Move ppb_nacl_private.h into components/nacl/renderer/ Since PPB_NaCl_Private is both implemented and consumed in components/nacl/renderer/, there's no need for the interface to be defined in ppapi/. The fact that this is a PPAPI interface at all is just a holdover from when the code for the NaCl trusted plugin lived outside the Chromium repo. We can drop the ppb_nacl_private.idl file. Benefits: * This reduces the friction for changing ppb_nacl_private.h. It's no longer necessary to change ppb_nacl_private.idl and re-run the generator. * This removes PPB_NaCl_Private from the PPAPI shims, reducing code size. * ppb_nacl_private.h no longer has to follow the PPAPI C header style. For example, it would no longer need to define its own "struct PP_NaClFileInfo" type -- it could share a definition that's marshallable over Chrome IPC. Changes to ppb_nacl_private.h: * Add comment to explain the status of this interface. * Remove unused "*_1_0" variants of #define and typedef. BUG=239656 BUG=251460 TEST=trybots Committed: https://crrev.com/3cf62d9ade1564df31b3887b01df5afad745a124 Cr-Commit-Position: refs/heads/master@{#315641}

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -911 lines) Patch
M chrome/browser/nacl_host/nacl_browser_delegate_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/test/nacl/nacl_browsertest_uma.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/renderer/file_downloader.h View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/renderer/histogram.h View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/renderer/json_manifest.h View 1 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/renderer/manifest_downloader.h View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/renderer/nexe_load_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/renderer/plugin/module_ppapi.h View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/renderer/plugin/plugin.h View 1 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/renderer/plugin/plugin.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M components/nacl/renderer/plugin/plugin_error.h View 1 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/renderer/plugin/pnacl_resources.h View 1 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/renderer/plugin/sel_ldr_launcher_chrome.h View 1 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/renderer/plugin/utility.h View 1 1 chunk +1 line, -1 line 0 comments Download
A + components/nacl/renderer/ppb_nacl_private.h View 1 2 4 chunks +18 lines, -22 lines 0 comments Download
M components/nacl/renderer/ppb_nacl_private_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/renderer/progress_event.h View 1 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/renderer/progress_event.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/browser/shell_nacl_browser_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/shell/renderer/shell_content_renderer_client.cc View 1 chunk +1 line, -1 line 0 comments Download
D ppapi/api/private/ppb_nacl_private.idl View 1 2 1 chunk +0 lines, -338 lines 0 comments Download
D ppapi/c/private/ppb_nacl_private.h View 1 2 1 chunk +0 lines, -363 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 6 chunks +0 lines, -166 lines 0 comments Download
M ppapi/ppapi_sources.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/tests/all_c_includes.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (5 generated)
Mark Seaborn
5 years, 10 months ago (2015-02-10 18:13:02 UTC) #2
dmichael (off chromium)
lgtm
5 years, 10 months ago (2015-02-10 18:20:14 UTC) #3
teravest
lgtm
5 years, 10 months ago (2015-02-10 18:23:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/911463003/40001
5 years, 10 months ago (2015-02-10 18:31:23 UTC) #6
Mark Seaborn
+thakis for chrome/renderer/ +jamescook for extensions/shell/
5 years, 10 months ago (2015-02-10 18:36:49 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/41753)
5 years, 10 months ago (2015-02-10 18:37:21 UTC) #10
James Cook
extensions/shell LGTM
5 years, 10 months ago (2015-02-10 19:55:10 UTC) #11
Nico
chrome/renderer lgtm
5 years, 10 months ago (2015-02-10 20:35:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/911463003/40001
5 years, 10 months ago (2015-02-10 20:36:55 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-10 21:20:11 UTC) #15
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 21:20:40 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3cf62d9ade1564df31b3887b01df5afad745a124
Cr-Commit-Position: refs/heads/master@{#315641}

Powered by Google App Engine
This is Rietveld 408576698