Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 911363002: Revert of new classes: implement new.target passing to superclass constructor. (Closed)

Created:
5 years, 10 months ago by Dmitry Lomov (no reviews)
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of new classes: implement new.target passing to superclass constructor. (patchset #9 id:150001 of https://codereview.chromium.org/908883002/) Reason for revert: Breaks Linux64 release Original issue's description: > new classes: implement new.target passing to superclass constructor. > > R=arv@chromium.org,rossberg@chromium.org > BUG=v8:3834 > LOG=N > > Committed: https://crrev.com/8aed43e82c6d2742fe5988603cb8841324cc942b > Cr-Commit-Position: refs/heads/master@{#26560} TBR=arv@chromium.org,rossberg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3834 Committed: https://crrev.com/8e4ec9dd1337cef884f5fea5f460cbe5e75d8d85 Cr-Commit-Position: refs/heads/master@{#26561}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -500 lines) Patch
M src/accessors.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/arm/builtins-arm.cc View 3 chunks +1 line, -6 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 5 chunks +1 line, -16 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 5 chunks +4 lines, -19 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 5 chunks +1 line, -17 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 5 chunks +4 lines, -19 lines 0 comments Download
M src/ast-value-factory.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/code.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/code-stubs.h View 4 chunks +3 lines, -16 lines 0 comments Download
M src/compiler.cc View 1 chunk +1 line, -6 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/compiler/linkage.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/deoptimizer.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M src/factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/frames.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/full-codegen.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/globals.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/hydrogen.cc View 2 chunks +1 line, -7 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 5 chunks +3 lines, -18 lines 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 4 chunks +4 lines, -18 lines 0 comments Download
M src/ic/ic.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/objects.h View 1 chunk +3 lines, -5 lines 0 comments Download
M src/objects-inl.h View 4 chunks +6 lines, -5 lines 0 comments Download
M src/runtime/runtime-classes.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-function.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/runtime/runtime-object.cc View 3 chunks +4 lines, -17 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/scopes.h View 3 chunks +2 lines, -7 lines 0 comments Download
M src/scopes.cc View 4 chunks +14 lines, -18 lines 0 comments Download
M src/variables.h View 2 chunks +5 lines, -2 lines 0 comments Download
M src/x64/builtins-x64.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 5 chunks +1 line, -14 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 5 chunks +3 lines, -20 lines 0 comments Download
M test/mjsunit/harmony/classes-experimental.js View 1 chunk +48 lines, -208 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dmitry Lomov (no reviews)
Created Revert of new classes: implement new.target passing to superclass constructor.
5 years, 10 months ago (2015-02-11 01:35:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/911363002/1
5 years, 10 months ago (2015-02-11 01:36:02 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-11 01:36:25 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 01:36:43 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e4ec9dd1337cef884f5fea5f460cbe5e75d8d85
Cr-Commit-Position: refs/heads/master@{#26561}

Powered by Google App Engine
This is Rietveld 408576698