Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: src/arm64/code-stubs-arm64.cc

Issue 911363002: Revert of new classes: implement new.target passing to superclass constructor. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm64/builtins-arm64.cc ('k') | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/arm64/code-stubs-arm64.cc
diff --git a/src/arm64/code-stubs-arm64.cc b/src/arm64/code-stubs-arm64.cc
index 28cbf7cde647fcc1afb7737d6fdd92ddd4b815a8..9a26c3d60b720c733870031ee79f9fc1f868d1ff 100644
--- a/src/arm64/code-stubs-arm64.cc
+++ b/src/arm64/code-stubs-arm64.cc
@@ -1643,7 +1643,6 @@
void ArgumentsAccessStub::GenerateReadElement(MacroAssembler* masm) {
- CHECK(!has_new_target());
Register arg_count = ArgumentsAccessReadDescriptor::parameter_count();
Register key = ArgumentsAccessReadDescriptor::index();
DCHECK(arg_count.is(x0));
@@ -1700,8 +1699,6 @@
// jssp[8]: address of receiver argument
// jssp[16]: function
- CHECK(!has_new_target());
-
// Check if the calling frame is an arguments adaptor frame.
Label runtime;
Register caller_fp = x10;
@@ -1732,8 +1729,6 @@
// jssp[16]: function
//
// Returns pointer to result object in x0.
-
- CHECK(!has_new_target());
// Note: arg_count_smi is an alias of param_count_smi.
Register arg_count_smi = x3;
@@ -2061,11 +2056,6 @@
MemOperand(caller_fp,
ArgumentsAdaptorFrameConstants::kLengthOffset));
__ SmiUntag(param_count, param_count_smi);
- if (has_new_target()) {
- // Skip new.target: it is not a part of arguments.
- __ Sub(param_count, param_count, Operand(1));
- __ SmiTag(param_count_smi, param_count);
- }
__ Add(x10, caller_fp, Operand(param_count, LSL, kPointerSizeLog2));
__ Add(params, x10, StandardFrameConstants::kCallerSPOffset);
@@ -2949,13 +2939,7 @@
__ AssertUndefinedOrAllocationSite(x2, x5);
}
- if (IsSuperConstructorCall()) {
- __ Mov(x4, Operand(1 * kPointerSize));
- __ Add(x4, x4, Operand(x0, LSL, kPointerSizeLog2));
- __ Peek(x3, x4);
- } else {
- __ Mov(x3, function);
- }
+ __ Mov(x3, function);
// Jump to the function-specific construct stub.
Register jump_reg = x4;
« no previous file with comments | « src/arm64/builtins-arm64.cc ('k') | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698