Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Unified Diff: components/password_manager/core/browser/test_password_store.cc

Issue 911323003: Simplify GetLoginsRequest, and let PasswordStore::GetLoginsImpl take scoped_ptr<GetLoginsRequest> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ps_fill_logins
Patch Set: Fix another Win compiler error. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/password_manager/core/browser/password_store_default.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/test_password_store.cc
diff --git a/components/password_manager/core/browser/test_password_store.cc b/components/password_manager/core/browser/test_password_store.cc
index 049a64167c770a5e93d78e41a2952d6b4d3fc707..a420e9e707b206bb4714f78c015b8beca60d3764 100644
--- a/components/password_manager/core/browser/test_password_store.cc
+++ b/components/password_manager/core/browser/test_password_store.cc
@@ -47,11 +47,12 @@ bool TestPasswordStore::FormsAreEquivalent(const autofill::PasswordForm& lhs,
void TestPasswordStore::GetAutofillableLoginsImpl(
scoped_ptr<GetLoginsRequest> request) {
+ ScopedVector<autofill::PasswordForm> results;
for (const auto& forms_for_realm : stored_passwords_) {
for (const autofill::PasswordForm& form : forms_for_realm.second)
- request->result()->push_back(new autofill::PasswordForm(form));
+ results.push_back(new autofill::PasswordForm(form));
}
- ForwardLoginsResult(request.Pass());
+ request->NotifyConsumerWithResults(results.Pass());
}
PasswordStoreChangeList TestPasswordStore::AddLoginImpl(
« no previous file with comments | « components/password_manager/core/browser/password_store_default.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698