components/password_manager/core/browser/password_store_default.cc - Issue 911323003: Simplify GetLoginsRequest, and let PasswordStore::GetLoginsImpl take scoped_ptr<GetLoginsRequest>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_store_default.cc

Issue 911323003: Simplify GetLoginsRequest, and let PasswordStore::GetLoginsImpl take scoped_ptr<GetLoginsRequest> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ps_fill_logins

Patch Set: Fix another Win compiler error. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_store.cc ('k') | components/password_manager/core/browser/test_password_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_store_default.cc

diff --git a/components/password_manager/core/browser/password_store_default.cc b/components/password_manager/core/browser/password_store_default.cc

index 81c4ca0a631527f37b6dff32f044c74e95136cab..88f6e9e45fe47f83a99df12fad70d62a5dd9e340 100644

--- a/components/password_manager/core/browser/password_store_default.cc

+++ b/components/password_manager/core/browser/password_store_default.cc

@@ -122,16 +122,16 @@ ScopedVector<autofill::PasswordForm> PasswordStoreDefault::FillMatchingLogins(

void PasswordStoreDefault::GetAutofillableLoginsImpl(

scoped_ptr<GetLoginsRequest> request) {

- DCHECK(request->result()->empty());

- FillAutofillableLogins(request->result());

- ForwardLoginsResult(request.Pass());

+ ScopedVector<autofill::PasswordForm> logins;

+ FillAutofillableLogins(&logins);

+ request->NotifyConsumerWithResults(logins.Pass());

}

void PasswordStoreDefault::GetBlacklistLoginsImpl(

scoped_ptr<GetLoginsRequest> request) {

- DCHECK(request->result()->empty());

- FillBlacklistLogins(request->result());

- ForwardLoginsResult(request.Pass());

+ ScopedVector<autofill::PasswordForm> logins;

+ FillBlacklistLogins(&logins);

+ request->NotifyConsumerWithResults(logins.Pass());

}

bool PasswordStoreDefault::FillAutofillableLogins(