chrome/browser/password_manager/password_store_win.h - Issue 911323003: Simplify GetLoginsRequest, and let PasswordStore::GetLoginsImpl take scoped_ptr<GetLoginsRequest>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_store_win.h

Issue 911323003: Simplify GetLoginsRequest, and let PasswordStore::GetLoginsImpl take scoped_ptr<GetLoginsRequest> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ps_fill_logins

Patch Set: Fix another Win compiler error. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_store_mac.cc ('k') | chrome/browser/password_manager/password_store_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_store_win.h

diff --git a/chrome/browser/password_manager/password_store_win.h b/chrome/browser/password_manager/password_store_win.h

index 9aed33d1a48e9d0a69ecee0e94f61e6b9d4b6c5f..8bf0cb7c3ce0c93e0295ea4f430066954e5804ea 100644

--- a/chrome/browser/password_manager/password_store_win.h

+++ b/chrome/browser/password_manager/password_store_win.h

@@ -46,7 +46,7 @@ class PasswordStoreWin : public password_manager::PasswordStoreDefault {

// password_manager::PasswordStore:

void GetLoginsImpl(const autofill::PasswordForm& form,

AuthorizationPromptPolicy prompt_policy,

- const ConsumerCallbackRunner& callback_runner) override;

+ scoped_ptr<GetLoginsRequest> request) override;

scoped_ptr<DBHandler> db_handler_;

« no previous file with comments | « chrome/browser/password_manager/password_store_mac.cc ('k') | chrome/browser/password_manager/password_store_win.cc » ('j') | no next file with comments »