Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3636)

Unified Diff: chrome/browser/password_manager/password_store_mac.cc

Issue 911323003: Simplify GetLoginsRequest, and let PasswordStore::GetLoginsImpl take scoped_ptr<GetLoginsRequest> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ps_fill_logins
Patch Set: Fix another Win compiler error. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/password_manager/password_store_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/password_manager/password_store_mac.cc
diff --git a/chrome/browser/password_manager/password_store_mac.cc b/chrome/browser/password_manager/password_store_mac.cc
index 6605c2eaa0f2e71038f4c2b88d88f401c8fa687c..f5bea72a79e19fcc77276dd7ead222cce9882be4 100644
--- a/chrome/browser/password_manager/password_store_mac.cc
+++ b/chrome/browser/password_manager/password_store_mac.cc
@@ -1086,16 +1086,16 @@ ScopedVector<autofill::PasswordForm> PasswordStoreMac::FillMatchingLogins(
void PasswordStoreMac::GetBlacklistLoginsImpl(
scoped_ptr<PasswordStore::GetLoginsRequest> request) {
- DCHECK(request->result()->empty());
- FillBlacklistLogins(request->result());
- ForwardLoginsResult(request.Pass());
+ ScopedVector<autofill::PasswordForm> obtained_forms;
+ FillBlacklistLogins(&obtained_forms);
+ request->NotifyConsumerWithResults(obtained_forms.Pass());
}
void PasswordStoreMac::GetAutofillableLoginsImpl(
scoped_ptr<PasswordStore::GetLoginsRequest> request) {
- DCHECK(request->result()->empty());
- FillAutofillableLogins(request->result());
- ForwardLoginsResult(request.Pass());
+ ScopedVector<autofill::PasswordForm> obtained_forms;
+ FillAutofillableLogins(&obtained_forms);
+ request->NotifyConsumerWithResults(obtained_forms.Pass());
}
bool PasswordStoreMac::FillAutofillableLogins(
« no previous file with comments | « no previous file | chrome/browser/password_manager/password_store_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698