Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 910883002: Update mojo sdk to rev 8af2ccff2eee4bfca1043015abee30482a030b30 (Closed)

Created:
5 years, 10 months ago by viettrungluu
Modified:
5 years, 10 months ago
Reviewers:
jamesr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update mojo sdk to rev 8af2ccff2eee4bfca1043015abee30482a030b30 Also apply mojo 8fda9302f51f99dc25e6e0c95cfd0a04e1adc802 (https://codereview.chromium.org/902783004/). Also apply mojo e62ed5fbf8bb4d7cfa87f499b1d1b50bdf8e0b3b (https://codereview.chromium.org/905253005/). Also apply dcf5a5e1dbccb91f774d545b5f31d06042d8a8e3 (https://codereview.chromium.org/909903003/). Also apply 9f87aeadbda22441b7d469e596f7bd7d0d73e2a8 (https://codereview.chromium.org/908973002/). (Reland of https://crrev.com/2e86fb9356e3a693762d3c86c70e63951bd9d1be a.k.a. refs/heads/master@{#315432}.) TBR=jamesr@chromium.org NOPRESUBMIT=true CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win8_chromium_gn_dbg,win8_chromium_gn_rel Committed: https://crrev.com/17e878ce6362ffe65a0893b601960f86556d6237 Cr-Commit-Position: refs/heads/master@{#315471}

Patch Set 1 #

Patch Set 2 : Apply mojo 8fda9302f51f99dc25e6e0c95cfd0a04e1adc802 (https://codereview.chromium.org/902783004). #

Patch Set 3 : Apply e62ed5fbf8bb4d7cfa87f499b1d1b50bdf8e0b3b (https://codereview.chromium.org/905253005/) #

Patch Set 4 : Apply dcf5a5e1dbccb91f774d545b5f31d06042d8a8e3 (https://codereview.chromium.org/909903003/) #

Patch Set 5 : Apply 9f87aeadbda22441b7d469e596f7bd7d0d73e2a8 (https://codereview.chromium.org/908973002/) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1505 lines, -448 lines) Patch
M third_party/mojo/src/mojo/edk/embedder/embedder.h View 1 chunk +30 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/embedder.cc View 1 5 chunks +42 lines, -32 lines 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/embedder_internal.h View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/edk/js/BUILD.gn View 2 chunks +15 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/channel_endpoint.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/channel_info.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/channel_manager.h View 4 chunks +17 lines, -11 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/channel_manager.cc View 4 chunks +43 lines, -24 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/channel_manager_unittest.cc View 3 chunks +8 lines, -20 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/connection_manager_unittest.cc View 11 chunks +22 lines, -11 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/master_connection_manager.h View 4 chunks +17 lines, -17 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/master_connection_manager.cc View 4 chunks +12 lines, -10 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/proxy_message_pipe_endpoint.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/slave_connection_manager.h View 4 chunks +16 lines, -16 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/slave_connection_manager.cc View 5 chunks +12 lines, -10 lines 0 comments Download
M third_party/mojo/src/mojo/public/VERSION View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/lib/validation_errors.h View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/lib/validation_errors.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/tests/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/tests/serialization_warning_unittest.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/tests/union_unittest.cc View 3 chunks +117 lines, -11 lines 0 comments Download
M third_party/mojo/src/mojo/public/go/system/core.go View 6 chunks +27 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/go/system/data_pipe.go View 6 chunks +18 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/go/system/handle.go View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/go/system/message_pipe.go View 2 chunks +7 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/go/system/mojo_types.go View 1 chunk +26 lines, -26 lines 0 comments Download
M third_party/mojo/src/mojo/public/go/system/shared_buffer.go View 3 chunks +9 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/interfaces/bindings/tests/test_unions.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/js/connection.js View 2 chunks +9 lines, -6 lines 0 comments Download
M third_party/mojo/src/mojo/public/mojo_application.gni View 1 chunk +4 lines, -6 lines 0 comments Download
M third_party/mojo/src/mojo/public/python/mojo_bindings/reflection.py View 8 chunks +25 lines, -43 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/BUILD.gn View 1 chunk +12 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/module-internal.h.tmpl View 3 chunks +13 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl View 1 2 4 chunks +16 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl View 3 chunks +24 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/params_definition.tmpl View 1 chunk +1 line, -1 line 0 comments Download
A third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/serialization_macros.tmpl View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/struct_declaration.tmpl View 1 chunk +1 line, -1 line 0 comments Download
D third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_declaration.tmpl View 1 chunk +0 lines, -5 lines 0 comments Download
A third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/union_declaration.tmpl View 1 chunk +50 lines, -0 lines 0 comments Download
A third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/union_definition.tmpl View 1 2 3 1 chunk +54 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl View 2 chunks +6 lines, -4 lines 0 comments Download
A third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/validation_macros.tmpl View 1 chunk +43 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/wrapper_union_class_declaration.tmpl View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/wrapper_union_class_definition.tmpl View 5 chunks +19 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/dart_templates/struct_definition.tmpl View 1 chunk +1 line, -1 line 0 comments Download
A third_party/mojo/src/mojo/public/tools/bindings/generators/go_templates/enum.tmpl View 1 chunk +20 lines, -0 lines 0 comments Download
A third_party/mojo/src/mojo/public/tools/bindings/generators/go_templates/interface.tmpl View 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/go_templates/source.tmpl View 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/mojo/src/mojo/public/tools/bindings/generators/go_templates/struct.tmpl View 1 chunk +219 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/java_templates/struct_definition.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_cpp_generator.py View 5 chunks +7 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_dart_generator.py View 3 chunks +2 lines, -13 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_go_generator.py View 2 chunks +188 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_java_generator.py View 3 chunks +2 lines, -13 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_python_generator.py View 4 chunks +3 lines, -31 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/python_templates/module.py.tmpl View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/mojom.gni View 1 chunk +10 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom/generate/data.py View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom/generate/generator.py View 4 chunks +15 lines, -12 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom/generate/module.py View 5 chunks +10 lines, -4 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom/generate/pack.py View 8 chunks +72 lines, -18 lines 0 comments Download
A + third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom_tests/generate/generator_unittest.py View 1 chunk +11 lines, -11 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom_tests/generate/pack_unittest.py View 1 chunk +42 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/download_shell_binary.py View 3 chunks +32 lines, -23 lines 0 comments Download
M third_party/mojo_services/src/public/js/shell.js View 1 chunk +6 lines, -3 lines 0 comments Download
M third_party/mojo_services/src/view_manager/public/cpp/lib/view.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/mojo_services/src/view_manager/public/cpp/lib/view_manager_client_factory.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/mojo_services/src/view_manager/public/cpp/lib/view_manager_client_impl.h View 5 chunks +6 lines, -4 lines 0 comments Download
M third_party/mojo_services/src/view_manager/public/cpp/lib/view_manager_client_impl.cc View 10 chunks +28 lines, -20 lines 0 comments Download
M third_party/mojo_services/src/view_manager/public/cpp/view_manager_client_factory.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/mojo_services/src/view_manager/public/interfaces/view_manager.mojom View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/mojo_services/src/window_manager/public/interfaces/window_manager_internal.mojom View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/910883002/60001
5 years, 10 months ago (2015-02-09 22:12:09 UTC) #2
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-09 23:31:00 UTC) #3
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/2e86fb9356e3a693762d3c86c70e63951bd9d1be Cr-Commit-Position: refs/heads/master@{#315432}
5 years, 10 months ago (2015-02-09 23:31:40 UTC) #4
jiayl
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/890843003/ by jiayl@chromium.org. ...
5 years, 10 months ago (2015-02-09 23:42:28 UTC) #5
viettrungluu
Was reverted. Will upload updated version. Note to self: win_chromium_compile_dbg_ng actually failed, but reported itself ...
5 years, 10 months ago (2015-02-10 00:10:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/910883002/80001
5 years, 10 months ago (2015-02-10 01:29:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/910883002/80001
5 years, 10 months ago (2015-02-10 01:32:30 UTC) #11
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 10 months ago (2015-02-10 02:03:57 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 02:04:47 UTC) #13
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/17e878ce6362ffe65a0893b601960f86556d6237
Cr-Commit-Position: refs/heads/master@{#315471}

Powered by Google App Engine
This is Rietveld 408576698