Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: third_party/mojo/src/mojo/edk/js/BUILD.gn

Issue 910883002: Update mojo sdk to rev 8af2ccff2eee4bfca1043015abee30482a030b30 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Apply 9f87aeadbda22441b7d469e596f7bd7d0d73e2a8 (https://codereview.chromium.org/908973002/) Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/mojo/src/mojo/edk/js/BUILD.gn
diff --git a/third_party/mojo/src/mojo/edk/js/BUILD.gn b/third_party/mojo/src/mojo/edk/js/BUILD.gn
index 9a066d33611e1fcc2fe2f8fb7474a6c1b6917c17..ed1b81f7fce951d1558991307958be578824987e 100644
--- a/third_party/mojo/src/mojo/edk/js/BUILD.gn
+++ b/third_party/mojo/src/mojo/edk/js/BUILD.gn
@@ -4,6 +4,20 @@
import("../mojo_edk.gni")
+# TODO(hansmuller): The organization of tests in this directory is weird:
+# * Really, js_unittests tests public stuff, so that should live in public
+# and be reworked as some sort of apptest.
+# * Both js_unittests and js_integration_tests should auto-generate their
+# tests somehow. The .cc files are just test runner stubs, including
+# explicit lists of .js files.
+group("tests") {
+ testonly = true
+ deps = [
+ "test:js_unittests",
+ "test:js_integration_tests",
+ ]
+}
+
mojo_edk_source_set("js") {
sources = [
"core.cc",
@@ -50,7 +64,5 @@ mojo_edk_source_set("js_unittests") {
"mojo/edk/test:test_support",
]
- mojo_sdk_deps = [
- "mojo/public/cpp/system",
- ]
+ mojo_sdk_deps = [ "mojo/public/cpp/system" ]
}
« no previous file with comments | « third_party/mojo/src/mojo/edk/embedder/embedder_internal.h ('k') | third_party/mojo/src/mojo/edk/system/channel_endpoint.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698