Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 910843002: Hoist checks for 'disabled' tracks out of textTrackAddCue{,s} (Closed)

Created:
5 years, 10 months ago by fs
Modified:
5 years, 10 months ago
Reviewers:
philipj_slow
CC:
blink-reviews, nessy, gasubic, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews-html_chromium.org, vcarbune.chromium
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Hoist checks for 'disabled' tracks out of textTrackAddCue{,s} In most cases the mode has already been checked by calling code, so the check is redundant. This is done in preparation of factoring the text track rendering code out of HTMLMediaElement. BUG=321654 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189944

Patch Set 1 #

Patch Set 2 : Missed a spot. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M Source/core/html/HTMLMediaElement.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/html/track/LoadableTextTrack.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/track/TextTrack.cpp View 1 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
fs
5 years, 10 months ago (2015-02-09 16:22:59 UTC) #2
philipj_slow
The bots look sad, but I'm very excited about "factoring the text track rendering code ...
5 years, 10 months ago (2015-02-10 04:14:08 UTC) #3
fs
On 2015/02/10 04:14:08, philipj_UTC7 wrote: > The bots look sad Apparently I had missed one ...
5 years, 10 months ago (2015-02-10 11:39:45 UTC) #4
philipj_slow
lgtm
5 years, 10 months ago (2015-02-11 01:46:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/910843002/20001
5 years, 10 months ago (2015-02-11 01:47:10 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 01:50:26 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189944

Powered by Google App Engine
This is Rietveld 408576698