Source/core/html/track/LoadableTextTrack.cpp - Issue 910843002: Hoist checks for 'disabled' tracks out of textTrackAddCue{,s}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/track/LoadableTextTrack.cpp

Issue 910843002: Hoist checks for 'disabled' tracks out of textTrackAddCue{,s} (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Missed a spot. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/track/LoadableTextTrack.cpp

diff --git a/Source/core/html/track/LoadableTextTrack.cpp b/Source/core/html/track/LoadableTextTrack.cpp

index dff3e17f7ff241e1ef053e5466ef9fff787762de..84b99fe3b1fdbff2cf99af15399b290d2ad45819 100644

--- a/Source/core/html/track/LoadableTextTrack.cpp

+++ b/Source/core/html/track/LoadableTextTrack.cpp

@@ -130,7 +130,7 @@ void LoadableTextTrack::newCuesAvailable(TextTrackLoader* loader)

m_cues->add(newCues[i].release());

}

- if (mediaElement())

+ if (mediaElement() && mode() != disabledKeyword())

mediaElement()->textTrackAddCues(this, m_cues.get());

}

« no previous file with comments | « Source/core/html/HTMLMediaElement.cpp ('k') | Source/core/html/track/TextTrack.cpp » ('j') | no next file with comments »