Remove JS summary.

Remove the JS key log summary, since it's of limited value without the "code" field. Also includes misc fixes for release.

* Change the title, since we're no longer just JS.
* Add a description for CWS.
* Update version number.

Committed: https://crrev.com/7a9ac6310a6ce95821213461911d7650654215dc
Cr-Commit-Position: refs/heads/master@{#315427}

[Jamie, 2015-02-07 02:07:29]

jamiewalch@chromium.org changed reviewers:
+ wez@chromium.org

[Jamie, 2015-02-07 02:07:29]

ptal

[Wez, 2015-02-07 02:14:08]

https://codereview.chromium.org/910483002/diff/20001/remoting/tools/javascrip...
File remoting/tools/javascript_key_tester/keyboard_map.js (right):

https://codereview.chromium.org/910483002/diff/20001/remoting/tools/javascrip...
remoting/tools/javascript_key_tester/keyboard_map.js:7: var keyboardMap = [
You should make clear that this map is US English, e.g. rename it to
usKeyCodeMap or similar.

Also suggest adding a reference to the bug to get rid of this table as soon as
Chrome supports KeyboardEvent.code.

https://codereview.chromium.org/910483002/diff/20001/remoting/tools/javascrip...
remoting/tools/javascript_key_tester/keyboard_map.js:26: 'Alt',  // NB: *not*
LeftAlt--not all keyboard layouts make the distinction.
I don't understand this comment; what's it got to do with the layout?  VKEY
values don't distinguish, so you have to actually look at the
KeyboardEvent.location to determine which it is.

https://codereview.chromium.org/910483002/diff/20001/remoting/tools/javascrip...
remoting/tools/javascript_key_tester/keyboard_map.js:233: 'RightAlt',
The 'code' name for this key is AltRight, not RightAlt.

https://codereview.chromium.org/910483002/diff/20001/remoting/tools/javascrip...
File remoting/tools/javascript_key_tester/manifest.json (right):

https://codereview.chromium.org/910483002/diff/20001/remoting/tools/javascrip...
remoting/tools/javascript_key_tester/manifest.json:2: "name": "Chrome key event
tester",
nit: App names seem to be more capitalized normally?

https://codereview.chromium.org/910483002/diff/20001/remoting/tools/javascrip...
remoting/tools/javascript_key_tester/manifest.json:3: "description": "Test
press, release and character events for JavaScript and PNaCl.",
s/PNaCl/PPAPI

Although your plugin is PNaCl, what you're testing is the events PPAPI
generates.

[Wez, 2015-02-07 02:16:47]

https://codereview.chromium.org/910483002/diff/20001/remoting/tools/javascrip...
File remoting/tools/javascript_key_tester/keyboard_map.js (right):

https://codereview.chromium.org/910483002/diff/20001/remoting/tools/javascrip...
remoting/tools/javascript_key_tester/keyboard_map.js:7: var keyboardMap = [
On 2015/02/07 02:14:07, Wez wrote:
> You should make clear that this map is US English, e.g. rename it to
> usKeyCodeMap or similar.
> 
> Also suggest adding a reference to the bug to get rid of this table as soon as
> Chrome supports KeyboardEvent.code.

In fact, to avoid confusion, I'd suggest prefixing the key names in here with
"Vk", so it's clear that they're not directly comparable to the values listed
for PPAPI (e.g. under a French layout, you will display KeyA for JS but KeyQ for
PPAPI)

[Jamie, 2015-02-09 19:10:20]

I've removed the JS section entirely, since it's not particularly useful without
"code" (and not useful for Chromoting even then).

PTAL.

https://codereview.chromium.org/910483002/diff/20001/remoting/tools/javascrip...
File remoting/tools/javascript_key_tester/manifest.json (right):

https://codereview.chromium.org/910483002/diff/20001/remoting/tools/javascrip...
remoting/tools/javascript_key_tester/manifest.json:2: "name": "Chrome key event
tester",
On 2015/02/07 02:14:08, Wez wrote:
> nit: App names seem to be more capitalized normally?

Done.

https://codereview.chromium.org/910483002/diff/20001/remoting/tools/javascrip...
remoting/tools/javascript_key_tester/manifest.json:3: "description": "Test
press, release and character events for JavaScript and PNaCl.",
On 2015/02/07 02:14:07, Wez wrote:
> s/PNaCl/PPAPI
> 
> Although your plugin is PNaCl, what you're testing is the events PPAPI
> generates.

Done.

[Wez, 2015-02-09 21:57:36]

lgtm

https://codereview.chromium.org/910483002/diff/40001/remoting/tools/javascrip...
File remoting/tools/javascript_key_tester/manifest.json (right):

https://codereview.chromium.org/910483002/diff/40001/remoting/tools/javascrip...
remoting/tools/javascript_key_tester/manifest.json:3: "description": "Test
press, release and character events for JavaScript and PPAPI.",
We're no longer logging for keydown & keyup, are we?

Also, "press, release and character events" is confusing, since DOM generates
"down", "press" and "up" events, i.e. press does not mean what you think it
does.

Are we going to also/alternatively log textInput events?

[Wez, 2015-02-09 21:57:53]

On 2015/02/09 21:57:36, Wez wrote:
> lgtm
> 
>
https://codereview.chromium.org/910483002/diff/40001/remoting/tools/javascrip...
> File remoting/tools/javascript_key_tester/manifest.json (right):
> 
>
https://codereview.chromium.org/910483002/diff/40001/remoting/tools/javascrip...
> remoting/tools/javascript_key_tester/manifest.json:3: "description": "Test
> press, release and character events for JavaScript and PPAPI.",
> We're no longer logging for keydown & keyup, are we?
> 
> Also, "press, release and character events" is confusing, since DOM generates
> "down", "press" and "up" events, i.e. press does not mean what you think it
> does.
> 
> Are we going to also/alternatively log textInput events?

*for JS keydown and keyup, I mean.

[Jamie, 2015-02-09 22:05:59]

The CQ bit was checked by jamiewalch@chromium.org

[Jamie, 2015-02-09 22:06:32]

FYI

https://codereview.chromium.org/910483002/diff/40001/remoting/tools/javascrip...
File remoting/tools/javascript_key_tester/manifest.json (right):

https://codereview.chromium.org/910483002/diff/40001/remoting/tools/javascrip...
remoting/tools/javascript_key_tester/manifest.json:3: "description": "Test
press, release and character events for JavaScript and PPAPI.",
On 2015/02/09 21:57:36, Wez wrote:
> We're no longer logging for keydown & keyup, are we?

We still log them to the detailed log, just not the summary.

> 
> Also, "press, release and character events" is confusing, since DOM generates
> "down", "press" and "up" events, i.e. press does not mean what you think it
> does.

Since PPAPI and DOM use different names for similar concepts, I think this is
adequate for an app description.

> 
> Are we going to also/alternatively log textInput events?

I wasn't planning on it, no. We can add it if we find a use for it.

[commit-bot: I haz the power, 2015-02-09 22:07:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/910483002/40001

[commit-bot: I haz the power, 2015-02-09 23:27:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-09 23:28:35]

Patchset 3 (id:??) landed as
https://crrev.com/7a9ac6310a6ce95821213461911d7650654215dc
Cr-Commit-Position: refs/heads/master@{#315427}