Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 910483002: Remove JS summary. (Closed)

Created:
5 years, 10 months ago by Jamie
Modified:
5 years, 10 months ago
Reviewers:
Wez
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the JS key log summary, since it's of limited value without the "code" field. Also includes misc fixes for release. * Change the title, since we're no longer just JS. * Add a description for CWS. * Update version number. Committed: https://crrev.com/7a9ac6310a6ce95821213461911d7650654215dc Cr-Commit-Position: refs/heads/master@{#315427}

Patch Set 1 #

Patch Set 2 : Update version number. #

Total comments: 8

Patch Set 3 : Reviewer feedback. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -323 lines) Patch
M remoting/remoting_key_tester.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M remoting/tools/javascript_key_tester/chord_tracker.js View 1 2 2 chunks +8 lines, -29 lines 0 comments Download
M remoting/tools/javascript_key_tester/event_listeners.js View 1 2 7 chunks +2 lines, -13 lines 0 comments Download
M remoting/tools/javascript_key_tester/keyboard_map.js View 1 2 1 chunk +0 lines, -264 lines 0 comments Download
M remoting/tools/javascript_key_tester/main.css View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M remoting/tools/javascript_key_tester/main.html View 1 2 1 chunk +1 line, -9 lines 0 comments Download
M remoting/tools/javascript_key_tester/main.js View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M remoting/tools/javascript_key_tester/manifest.json View 1 2 1 chunk +3 lines, -2 lines 2 comments Download

Messages

Total messages: 12 (2 generated)
Jamie
ptal
5 years, 10 months ago (2015-02-07 02:07:29 UTC) #2
Wez
https://codereview.chromium.org/910483002/diff/20001/remoting/tools/javascript_key_tester/keyboard_map.js File remoting/tools/javascript_key_tester/keyboard_map.js (right): https://codereview.chromium.org/910483002/diff/20001/remoting/tools/javascript_key_tester/keyboard_map.js#newcode7 remoting/tools/javascript_key_tester/keyboard_map.js:7: var keyboardMap = [ You should make clear that ...
5 years, 10 months ago (2015-02-07 02:14:08 UTC) #3
Wez
https://codereview.chromium.org/910483002/diff/20001/remoting/tools/javascript_key_tester/keyboard_map.js File remoting/tools/javascript_key_tester/keyboard_map.js (right): https://codereview.chromium.org/910483002/diff/20001/remoting/tools/javascript_key_tester/keyboard_map.js#newcode7 remoting/tools/javascript_key_tester/keyboard_map.js:7: var keyboardMap = [ On 2015/02/07 02:14:07, Wez wrote: ...
5 years, 10 months ago (2015-02-07 02:16:47 UTC) #4
Jamie
I've removed the JS section entirely, since it's not particularly useful without "code" (and not ...
5 years, 10 months ago (2015-02-09 19:10:20 UTC) #5
Wez
lgtm https://codereview.chromium.org/910483002/diff/40001/remoting/tools/javascript_key_tester/manifest.json File remoting/tools/javascript_key_tester/manifest.json (right): https://codereview.chromium.org/910483002/diff/40001/remoting/tools/javascript_key_tester/manifest.json#newcode3 remoting/tools/javascript_key_tester/manifest.json:3: "description": "Test press, release and character events for ...
5 years, 10 months ago (2015-02-09 21:57:36 UTC) #6
Wez
On 2015/02/09 21:57:36, Wez wrote: > lgtm > > https://codereview.chromium.org/910483002/diff/40001/remoting/tools/javascript_key_tester/manifest.json > File remoting/tools/javascript_key_tester/manifest.json (right): > ...
5 years, 10 months ago (2015-02-09 21:57:53 UTC) #7
Jamie
FYI https://codereview.chromium.org/910483002/diff/40001/remoting/tools/javascript_key_tester/manifest.json File remoting/tools/javascript_key_tester/manifest.json (right): https://codereview.chromium.org/910483002/diff/40001/remoting/tools/javascript_key_tester/manifest.json#newcode3 remoting/tools/javascript_key_tester/manifest.json:3: "description": "Test press, release and character events for ...
5 years, 10 months ago (2015-02-09 22:06:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/910483002/40001
5 years, 10 months ago (2015-02-09 22:07:20 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-09 23:27:25 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 23:28:35 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7a9ac6310a6ce95821213461911d7650654215dc
Cr-Commit-Position: refs/heads/master@{#315427}

Powered by Google App Engine
This is Rietveld 408576698