remoting/tools/javascript_key_tester/manifest.json - Issue 910483002: Remove JS summary.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/tools/javascript_key_tester/manifest.json

Issue 910483002: Remove JS summary. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reviewer feedback. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 {	1 {

2 "name": "Javascript key event tester",	2 "name": "Chrome Key Event Tester",

3 "version": "1.1",	3 "description": "Test press, release and character events for JavaScript and PP API.",
	Wez 2015/02/09 21:57:36 We're no longer logging for keydown & keyup, are w We're no longer logging for keydown & keyup, are we? Also, "press, release and character events" is confusing, since DOM generates "down", "press" and "up" events, i.e. press does not mean what you think it does. Are we going to also/alternatively log textInput events? Jamie 2015/02/09 22:06:31 We still log them to the detailed log, just not th Show quoted text On 2015/02/09 21:57:36, Wez wrote: > We're no longer logging for keydown & keyup, are we? We still log them to the detailed log, just not the summary. Show quoted text > > Also, "press, release and character events" is confusing, since DOM generates > "down", "press" and "up" events, i.e. press does not mean what you think it > does. Since PPAPI and DOM use different names for similar concepts, I think this is adequate for an app description. Show quoted text > > Are we going to also/alternatively log textInput events? I wasn't planning on it, no. We can add it if we find a use for it.
	4 "version": "1.2",

4 "manifest_version": 2,	5 "manifest_version": 2,

5 "icons": {	6 "icons": {

6 "128": "icon_128.png"	7 "128": "icon_128.png"

7 },	8 },

8 "app": {	9 "app": {

9 "background": {	10 "background": {

10 "scripts": ["background.js"]	11 "scripts": ["background.js"]

11 }	12 }

12 }	13 }

13 }	14 }

OLD	NEW

« no previous file with comments | « remoting/tools/javascript_key_tester/main.js ('k') | no next file » | no next file with comments »