Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 910213002: Use conics for round joins and caps (Closed)

Created:
5 years, 10 months ago by reed1
Modified:
5 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use conics for round joins and caps patch from issue 909013004 at patchset 20001 (http://crrev.com/909013004#ps20001) BUG=skia: TBR=caryclark Committed: https://skia.googlesource.com/skia/+/88f0a99fd48cfb30ca5596182f8932d76cd76f17

Patch Set 1 #

Patch Set 2 : apply simplification suggestion from prev CL #

Patch Set 3 : remove dup cubic code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -9 lines) Patch
M src/core/SkGeometry.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/core/SkGeometry.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkStrokerPriv.cpp View 1 2 3 chunks +26 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
reed1
5 years, 10 months ago (2015-02-10 15:15:44 UTC) #2
caryclark
lgtm
5 years, 10 months ago (2015-02-10 15:41:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/910213002/40001
5 years, 10 months ago (2015-02-10 16:21:00 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 16:45:11 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/88f0a99fd48cfb30ca5596182f8932d76cd76f17

Powered by Google App Engine
This is Rietveld 408576698