extensions/common/api/guest_view_internal.json - Issue 910073003: <webview>: Make contentWindow available prior to attachment (on display:none).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/api/guest_view_internal.json

Issue 910073003: <webview>: Make contentWindow available prior to attachment (on display:none). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed nit Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/guest_view/web_view/web_view_guest.cc ('k') | extensions/common/guest_view/guest_view_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/api/guest_view_internal.json

diff --git a/extensions/common/api/guest_view_internal.json b/extensions/common/api/guest_view_internal.json

index ddf8ce9457ceeea32e2597c5c34dc5d662e8ca58..90c5d4e7b0e81a7f8106c2c3cb767de61473856d 100644

--- a/extensions/common/api/guest_view_internal.json

+++ b/extensions/common/api/guest_view_internal.json

@@ -66,8 +66,9 @@

"name": "callback",

"parameters": [

{

- "type": "integer",

- "name": "instanceId"

+ "type": "object",

+ "name": "returnParams",

+ "additionalProperties": {"type": "any"}

}

]

}

« no previous file with comments | « extensions/browser/guest_view/web_view/web_view_guest.cc ('k') | extensions/common/guest_view/guest_view_constants.h » ('j') | no next file with comments »