Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: extensions/browser/guest_view/web_view/web_view_guest.cc

Issue 910073003: <webview>: Make contentWindow available prior to attachment (on display:none). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed nit Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/web_view/web_view_guest.cc
diff --git a/extensions/browser/guest_view/web_view/web_view_guest.cc b/extensions/browser/guest_view/web_view/web_view_guest.cc
index 8b9bfb0391399deca42ff8a2b7724d372417e117..76712fa7325c1d1a5c274e2801e65ae5abc09943 100644
--- a/extensions/browser/guest_view/web_view/web_view_guest.cc
+++ b/extensions/browser/guest_view/web_view/web_view_guest.cc
@@ -983,7 +983,6 @@ void WebViewGuest::ApplyAttributes(const base::DictionaryValue& params) {
params.GetString(webview::kAttributeSrc, &src);
NavigateGuest(src, false /* force_navigation */);
}
-
}
void WebViewGuest::ShowContextMenu(
@@ -1077,7 +1076,7 @@ bool WebViewGuest::LoadDataWithBaseURL(const std::string& data_url,
content::NavigationController::UA_OVERRIDE_INHERIT;
// Navigate to the data URL.
- web_contents()->GetController().LoadURLWithParams(load_params);
+ GuestViewBase::LoadURLWithParams(load_params);
return true;
}
@@ -1205,7 +1204,7 @@ void WebViewGuest::LoadURLWithParams(const GURL& url,
load_url_params.override_user_agent =
content::NavigationController::UA_OVERRIDE_TRUE;
}
- web_contents()->GetController().LoadURLWithParams(load_url_params);
+ GuestViewBase::LoadURLWithParams(load_url_params);
src_ = validated_url;
}
« no previous file with comments | « extensions/browser/guest_view/guest_view_message_filter.cc ('k') | extensions/common/api/guest_view_internal.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698