extensions/renderer/guest_view/guest_view_internal_custom_bindings.h - Issue 910073003: <webview>: Make contentWindow available prior to attachment (on display:none).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/guest_view/guest_view_internal_custom_bindings.h

Issue 910073003: <webview>: Make contentWindow available prior to attachment (on display:none). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/guest_view/web_view/web_view_guest.cc ('K') | « extensions/common/guest_view/guest_view_constants.cc ('k') | extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/guest_view/guest_view_internal_custom_bindings.h

diff --git a/extensions/renderer/guest_view/guest_view_internal_custom_bindings.h b/extensions/renderer/guest_view/guest_view_internal_custom_bindings.h

index 0c29435f411e6e029cea109fe61fd3480cf7362f..2c191373f4460cf477bf916a33d0f44e4082c011 100644

--- a/extensions/renderer/guest_view/guest_view_internal_custom_bindings.h

+++ b/extensions/renderer/guest_view/guest_view_internal_custom_bindings.h

@@ -40,6 +40,10 @@ class GuestViewInternalCustomBindings : public ObjectBackedNativeHandler {

// been detached.

void DetachGuest(const v8::FunctionCallbackInfo<v8::Value>& args);

+ // GetContentWindow takes in a RenderView routing ID and returns the

+ // Window JavaScript object for that RenderView.

+ void GetContentWindow(const v8::FunctionCallbackInfo<v8::Value>& args);

// RegisterDestructionCallback registers a JavaScript callback function to be

// called when the guestview's container is destroyed.

// RegisterDestructionCallback takes in a single paramater, |callback|.