extensions/browser/guest_view/web_view/web_view_guest.cc - Issue 910073003: <webview>: Make contentWindow available prior to attachment (on display:none).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/web_view_guest.cc

Issue 910073003: <webview>: Make contentWindow available prior to attachment (on display:none). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/browser/guest_proxy_host.h ('K') | « extensions/browser/guest_view/guest_view_message_filter.cc ('k') | extensions/common/api/guest_view_internal.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/web_view/web_view_guest.cc

diff --git a/extensions/browser/guest_view/web_view/web_view_guest.cc b/extensions/browser/guest_view/web_view/web_view_guest.cc

index 8b9bfb0391399deca42ff8a2b7724d372417e117..994e9b311d64ac347ea4523785c823b10ca396d4 100644

--- a/extensions/browser/guest_view/web_view/web_view_guest.cc

+++ b/extensions/browser/guest_view/web_view/web_view_guest.cc

@@ -984,6 +984,7 @@ void WebViewGuest::ApplyAttributes(const base::DictionaryValue& params) {

NavigateGuest(src, false /* force_navigation */);

}

+ ignore_result(proxy_host()->GetGuestProxyRoutingID());

lfg 2015/03/05 22:14:00 Comment that this is here to create the RV.

Fady Samuel 2015/03/07 00:20:28 Removed.

}

void WebViewGuest::ShowContextMenu(