Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: extensions/browser/guest_view/guest_view_base.h

Issue 910073003: <webview>: Make contentWindow available prior to attachment (on display:none). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/guest_view_base.h
diff --git a/extensions/browser/guest_view/guest_view_base.h b/extensions/browser/guest_view/guest_view_base.h
index c3f8f766f0f9ad02cdbf2348c784c02f1725a7a7..8c8bd5cbb94c066cd8fbb6ff633a6b96ac0e416d 100644
--- a/extensions/browser/guest_view/guest_view_base.h
+++ b/extensions/browser/guest_view/guest_view_base.h
@@ -11,7 +11,7 @@
#include "base/values.h"
#include "components/ui/zoom/zoom_observer.h"
#include "content/public/browser/browser_plugin_guest_delegate.h"
-#include "content/public/browser/guest_sizer.h"
+#include "content/public/browser/guest_proxy_host.h"
#include "content/public/browser/render_process_host_observer.h"
#include "content/public/browser/web_contents.h"
#include "content/public/browser/web_contents_delegate.h"
@@ -216,6 +216,10 @@ class GuestViewBase : public content::BrowserPluginGuestDelegate,
return owner_web_contents_;
}
+ content::GuestProxyHost* proxy_host() const {
+ return guest_proxy_host_;
+ }
+
// Returns the parameters associated with the element hosting this GuestView
// passed in from JavaScript.
base::DictionaryValue* attach_params() const { return attach_params_.get(); }
@@ -267,12 +271,11 @@ class GuestViewBase : public content::BrowserPluginGuestDelegate,
// BrowserPluginGuestDelegate implementation.
content::WebContents* CreateNewGuestWindow(
const content::WebContents::CreateParams& create_params) final;
- void DidAttach(int guest_proxy_routing_id) final;
+ void DidAttach() final;
void DidDetach() final;
content::WebContents* GetOwnerWebContents() const final;
void GuestSizeChanged(const gfx::Size& new_size) final;
- void RegisterDestructionCallback(const DestructionCallback& callback) final;
- void SetGuestSizer(content::GuestSizer* guest_sizer) final;
+ void SetGuestProxyHost(content::GuestProxyHost* guest_proxy_host) final;
void WillAttach(content::WebContents* embedder_web_contents,
int browser_plugin_instance_id,
bool is_full_page_plugin) final;
@@ -396,8 +399,6 @@ class GuestViewBase : public content::BrowserPluginGuestDelegate,
// The opener guest view.
base::WeakPtr<GuestViewBase> opener_;
- DestructionCallback destruction_callback_;
-
// The parameters associated with the element hosting this GuestView that
// are passed in from JavaScript. This will typically be the view instance ID,
// and element-specific parameters. These parameters are passed along to new
@@ -416,8 +417,8 @@ class GuestViewBase : public content::BrowserPluginGuestDelegate,
// element may not match the size of the guest.
gfx::Size guest_size_;
- // A pointer to the guest_sizer.
- content::GuestSizer* guest_sizer_;
+ // A pointer to the guest_proxy_host.
+ content::GuestProxyHost* guest_proxy_host_;
// Indicates whether autosize mode is enabled or not.
bool auto_size_enabled_;

Powered by Google App Engine
This is Rietveld 408576698