Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 91003002: Avoid useless #ifdef DEBUG checks for the --trace-ic flag. (Closed)

Created:
7 years ago by Benedikt Meurer
Modified:
7 years ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Avoid useless #ifdef DEBUG checks for the --trace-ic flag. FLAG_trace_ic is constant false in non-DEBUG builds anyways. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18092

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M src/arm/ic-arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/code-stubs.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/ic.cc View 6 chunks +0 lines, -10 lines 0 comments Download
M src/mips/ic-mips.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
PTAL
7 years ago (2013-11-27 08:46:11 UTC) #1
Sven Panne
lgtm
7 years ago (2013-11-27 09:22:00 UTC) #2
Benedikt Meurer
7 years ago (2013-11-27 09:24:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18092 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698