Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 910013003: Mac: Fix crash due to occluding view during tear-down (Closed)

Created:
5 years, 10 months ago by ccameron
Modified:
5 years, 10 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac: Fix crash due to occluding view during tear-down WebContentsViewMac will get a call during WebContentsImpl's destructor, indicating that the contents are being occluded. It is not very helpful to forward this to the WebContentsImpl (because it's being destroyed anyway), and is dangerous in that the WebContentsImpl or its sub-structures may be in an inconsistent state and not expecting to be called in to. In particular, in the bug, we were destroying the FrameTree high in the stack, and then trying to iterate over it lower in the stack. BUG=429993 Committed: https://crrev.com/f128f129f90a6baf20e2dd30e3ce55f30d3d8a0d Cr-Commit-Position: refs/heads/master@{#315430}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/web_contents/web_contents_view_mac.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
ccameron
Small fix for browser crash issue.
5 years, 10 months ago (2015-02-09 21:44:51 UTC) #2
Avi (use Gerrit)
lgtm
5 years, 10 months ago (2015-02-09 21:57:43 UTC) #3
ccameron
Thanks!
5 years, 10 months ago (2015-02-09 22:23:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/910013003/1
5 years, 10 months ago (2015-02-09 22:25:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-09 23:28:57 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 23:29:28 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f128f129f90a6baf20e2dd30e3ce55f30d3d8a0d
Cr-Commit-Position: refs/heads/master@{#315430}

Powered by Google App Engine
This is Rietveld 408576698