content/browser/web_contents/web_contents_view_mac.mm - Issue 910013003: Mac: Fix crash due to occluding view during tear-down

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_view_mac.mm

Issue 910013003: Mac: Fix crash due to occluding view during tear-down (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/web_contents/web_contents_view_mac.mm

diff --git a/content/browser/web_contents/web_contents_view_mac.mm b/content/browser/web_contents/web_contents_view_mac.mm

index 27989c3951ffce334f0a2f48c2db99b67f3695df..91a4f5d2667450a7b4d3f10e12196999f0a69316 100644

--- a/content/browser/web_contents/web_contents_view_mac.mm

+++ b/content/browser/web_contents/web_contents_view_mac.mm

@@ -627,7 +627,7 @@ void WebContentsViewMac::CloseTab() {

DCHECK(base::mac::IsOSMavericksOrLater());

NSWindow* window = [notification object];

WebContentsImpl* webContents = [self webContents];

- if (window && webContents) {

+ if (window && webContents && !webContents->IsBeingDestroyed()) {

if ([window occlusionState] & NSWindowOcclusionStateVisible) {

webContents->WasUnOccluded();

} else {

« no previous file with comments | « no previous file | no next file » | no next file with comments »