Prepare SkiaBenchmarkingExtensionTest for upcoming Skia changes

Prepare SkiaBenchmarkingExtensionTest for upcoming Skia changes

Skia's SkDrawCommand will be changing. This CL prepares Chromium's unit test for the upcoming changes.

This will need to land after https://codereview.chromium.org/916983002/ (Add staging for Chromium) rolls into Chromium.

BUG=457691
Committed: https://crrev.com/e83e75ca1c84027a9fa78556e2876a48007f5bd2
Cr-Commit-Position: refs/heads/master@{#316027}

[robertphillips, 2015-02-11 22:51:07]

robertphillips@google.com changed reviewers:
+ creis@chromium.org

[robertphillips, 2015-02-11 23:01:45]

https://codereview.chromium.org/909353004/diff/1/content/renderer/skia_benchm...
File content/renderer/skia_benchmarking_extension_unittest.cc (right):

https://codereview.chromium.org/909353004/diff/1/content/renderer/skia_benchm...
content/renderer/skia_benchmarking_extension_unittest.cc:80: 
Skia converts all the matrix calls to a setMatrix when they're sent through a
picture.

[Charlie Reis, 2015-02-11 23:24:19]

creis@chromium.org changed reviewers:
+ sievers@chromium.org

[Charlie Reis, 2015-02-11 23:24:19]

I don't know Skia very well, so I'm not a great reviewer for this.  Maybe
sievers@ does?  Otherwise I can offer a rubber stamp after a Skia person reviews
it.

Is there a bug number we can list to tie the two CLs together?  And will the
bots be red between the two CLs landing?

[robertphillips, 2015-02-12 14:09:47]

robertphillips@google.com changed reviewers:
+ jvanverth@google.com, reed@google.com

[robertphillips, 2015-02-12 14:15:15]

Added some Skia-side reviewers. The bots will not go red in between the patches.

There are actually 3 patches involved:

The real Skia-side patch:

https://codereview.chromium.org/912403004/ (Remove SkPictureFlat.h include from
SkDrawCommands.h) - which cleans up an inappropriate Skia-internal header
export. If this were landed alone it would turn the Chromium bots red.

A Skia-side staging patch which will allows this patch to land:
https://codereview.chromium.org/916983002 (Add staging for Chromium).

And finally this patch that merely updates the Chromium test so that it will
work when the real patch lands.

[robertphillips, 2015-02-12 16:48:58]

The Skia-side staging patch has landed and been rolled into Chromium in
https://codereview.chromium.org/917183002/

[Jvsquare, 2015-02-12 16:57:19]

On 2015/02/12 16:48:58, robertphillips wrote:
> The Skia-side staging patch has landed and been rolled into Chromium in
> https://codereview.chromium.org/917183002/

LGTM

[no sievers, 2015-02-12 18:37:30]

lgtm

[robertphillips, 2015-02-12 19:14:58]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2015-02-12 19:15:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/909353004/1

[commit-bot: I haz the power, 2015-02-12 19:41:01]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-02-12 19:42:00]

Patchset 1 (id:??) landed as
https://crrev.com/e83e75ca1c84027a9fa78556e2876a48007f5bd2
Cr-Commit-Position: refs/heads/master@{#316027}