Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 916983002: Add staging for Chromium (Closed)

Created:
5 years, 10 months ago by robertphillips
Modified:
5 years, 10 months ago
Reviewers:
jvanverth1, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add staging for Chromium This staging is needed to land https://codereview.chromium.org/912403004/ (Remove SkPictureFlat.h include from SkDrawCommands.h) Committed: https://skia.googlesource.com/skia/+/72942b8eb56f17e9303380d4e8492f66e9330578

Patch Set 1 #

Patch Set 2 : Fix compilation issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M src/utils/debugger/SkDrawCommand.h View 1 1 chunk +16 lines, -0 lines 0 comments Download
M src/utils/debugger/SkDrawCommand.cpp View 1 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
robertphillips
5 years, 10 months ago (2015-02-11 22:45:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/916983002/20001
5 years, 10 months ago (2015-02-11 22:46:06 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-11 22:46:07 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
5 years, 10 months ago (2015-02-12 04:46:14 UTC) #7
robertphillips
5 years, 10 months ago (2015-02-12 14:07:17 UTC) #9
jvanverth1
lgtm
5 years, 10 months ago (2015-02-12 14:34:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/916983002/20001
5 years, 10 months ago (2015-02-12 14:37:04 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 14:37:18 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/72942b8eb56f17e9303380d4e8492f66e9330578

Powered by Google App Engine
This is Rietveld 408576698