Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1121)

Unified Diff: ui/views/accessibility/native_view_accessibility_win_unittest.cc

Issue 909143003: Re-land: Implement NativeViewAccessibilityWin using AXPlatformNodeWin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unit test Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/accessibility/native_view_accessibility_win_unittest.cc
diff --git a/ui/views/accessibility/native_view_accessibility_win_unittest.cc b/ui/views/accessibility/native_view_accessibility_win_unittest.cc
index 3edab8e258e963ed39408b42f0f292a3f64b5e96..bd9fd143eaee23c542e4728bbb4ab3395602d68a 100644
--- a/ui/views/accessibility/native_view_accessibility_win_unittest.cc
+++ b/ui/views/accessibility/native_view_accessibility_win_unittest.cc
@@ -81,35 +81,6 @@ TEST_F(NativeViewAcccessibilityWinTest, TextfieldAccessibility) {
ASSERT_STREQ(L"New value", textfield->text().c_str());
}
-TEST_F(NativeViewAcccessibilityWinTest, UnattachedWebView) {
David Tseng 2015/02/18 19:51:19 What happened to this test?
dmazzoni 2015/02/18 23:20:20 Deleted on purpose because I got rid of the code t
- // This is a regression test. Calling get_accChild on the native accessible
- // object for a WebView with no attached WebContents was causing an
- // infinite loop and crash. This test simulates that with an ordinary
- // View that registers itself as a web view with NativeViewAcccessibility.
-
- Widget widget;
- Widget::InitParams init_params =
- CreateParams(Widget::InitParams::TYPE_POPUP);
- init_params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
- widget.Init(init_params);
-
- View* content = new View;
- widget.SetContentsView(content);
-
- View* web_view = new View;
- content->AddChildView(web_view);
- NativeViewAccessibility::RegisterWebView(web_view);
-
- ScopedComPtr<IAccessible> web_view_accessible(
- web_view->GetNativeViewAccessible());
- ScopedComPtr<IDispatch> result_dispatch;
- ScopedVariant child_index(-999);
- ASSERT_EQ(E_FAIL, web_view_accessible->get_accChild(
- child_index, result_dispatch.Receive()));
-
- NativeViewAccessibility::UnregisterWebView(web_view);
-}
-
TEST_F(NativeViewAcccessibilityWinTest, AuraOwnedWidgets) {
Widget widget;
Widget::InitParams init_params =

Powered by Google App Engine
This is Rietveld 408576698