Re-land: Implement NativeViewAccessibilityWin using AXPlatformNodeWin.

ui/views/accessibility/native_view_accessibility_win_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <oleacc.h>
 
 #include "base/win/scoped_bstr.h"
 #include "base/win/scoped_comptr.h"
 #include "base/win/scoped_variant.h"
 #include "third_party/iaccessible2/ia2_api_all.h"
@@ skipping 63 matching lines @@
   ASSERT_EQ(S_OK, textfield_accessible->get_accValue(
       childid_self, value.Receive()));
   ASSERT_STREQ(L"Value", value);
 
   ScopedBstr new_value(L"New value");
   ASSERT_EQ(S_OK, textfield_accessible->put_accValue(childid_self, new_value));
 
   ASSERT_STREQ(L"New value", textfield->text().c_str());
 }
 
-TEST_F(NativeViewAcccessibilityWinTest, UnattachedWebView) {

[David Tseng, 2015/02/18 19:51:19]

What happened to this test?

[dmazzoni, 2015/02/18 23:20:20]

Deleted on purpose because I got rid of the code that registers WebViews.

In the early days of Win Aura, I added code to keep track of WebViews so that
get_accChild could handle unique ids inside web content, not just in views. It
was roundabout and ugly because ui/views can't depend on content/ and content/
can't depend on ui/views.

We ended up not needing that code because we created LegacyRenderWidgetHostHWND
and put the web content accessibility inside that HWND. However, if we end up
needing something similar in the future it will be much cleaner because we can
implement things in ui/accessibility that are shared by both content/ and
ui/views.

-  // This is a regression test. Calling get_accChild on the native accessible
-  // object for a WebView with no attached WebContents was causing an
-  // infinite loop and crash. This test simulates that with an ordinary
-  // View that registers itself as a web view with NativeViewAcccessibility.
-
-  Widget widget;
-  Widget::InitParams init_params =
-      CreateParams(Widget::InitParams::TYPE_POPUP);
-  init_params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
-  widget.Init(init_params);
-
-  View* content = new View;
-  widget.SetContentsView(content);
-
-  View* web_view = new View;
-  content->AddChildView(web_view);
-  NativeViewAccessibility::RegisterWebView(web_view);
-
-  ScopedComPtr<IAccessible> web_view_accessible(
-      web_view->GetNativeViewAccessible());
-  ScopedComPtr<IDispatch> result_dispatch;
-  ScopedVariant child_index(-999);
-  ASSERT_EQ(E_FAIL, web_view_accessible->get_accChild(
-      child_index, result_dispatch.Receive()));
-
-  NativeViewAccessibility::UnregisterWebView(web_view);
-}
-
 TEST_F(NativeViewAcccessibilityWinTest, AuraOwnedWidgets) {
   Widget widget;
   Widget::InitParams init_params =
       CreateParams(Widget::InitParams::TYPE_WINDOW);
   init_params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
   widget.Init(init_params);
 
   ScopedComPtr<IAccessible> root_view_accessible(
       widget.GetRootView()->GetNativeViewAccessible());
 
@@ skipping 72 matching lines @@
   delete infobar;
   ASSERT_EQ(S_OK, root_view_accessible->get_relationTargetsOfType(
       alerts_bstr, 0, &targets, &n_targets));
   ASSERT_EQ(1, n_targets);
   ASSERT_TRUE(infobar2_accessible.IsSameObject(targets[0]));
   CoTaskMemFree(targets);
 }
 
 }  // namespace test
 }  // namespace views